fix: swap toRemove & toAdd in deltaExtensions #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When we try to remove & add the same extension in a very short timeframe, it does not get initialized properly because it gets both added to `toRemove` and `toAdd`. When that happens, the extension is first added, and then immediately removed. By swapping `toRemove` and `toAdd` we ensure that the extension is first removed, and then newly added.
|
Thank you! |
CGNonofr
approved these changes
Nov 7, 2023
|
Let's wait until all PRs are merged before releasing a new version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we try to remove & add the same extension in a very short timeframe, it does not get initialized properly because it gets both added to
toRemoveandtoAdd. When that happens, the extension is first added, and then immediately removed. By swappingtoRemoveandtoAddwe ensure that the extension is first removed, and then newly added.Here's similar code in VSCode where I think they encountered the same condition: