Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Section tag parse while child tags are not found #1557

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Commits on Aug 7, 2023

  1. Fix: allow the import of gpx files that use displayScale as Float xml…

    … node instead Double
    
    Fix the import of some gpx files that uses <Float>instead <Double> node on XProperties
    
    Example
    ```xml
    <Bar id="29">
      <Clef>G2</Clef>
      <Voices>26 -1 -1 -1</Voices>
      <XProperties>
        <XProperty id="1124139520">
          <Float>1.07818</Float>
        </XProperty>
      </XProperties>
    </Bar>
    ```
    allandiego committed Aug 7, 2023
    Configuration menu
    Copy the full SHA
    3efa524 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. Configuration menu
    Copy the full SHA
    8dc5c4a View commit details
    Browse the repository at this point in the history
  2. fix: Add support for non-mandatory tags in Section parse

    Adds support for xml Section parsing where sometimes some child tags may not exist, like in this example where only Text child tag is present
    
    ```xml
    <Section><Text><![CDATA[Pre-Chorus]]></Text></Section>
    ```
    allandiego committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    caadb1e View commit details
    Browse the repository at this point in the history