Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Section tag parse while child tags are not found #1557

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Fix Section tag parse while child tags are not found #1557

wants to merge 3 commits into from

Conversation

allandiego
Copy link
Contributor

Issues

Fixes #1556

Proposed changes

set a default empty string value if the child tag is not found

Checklist

  • I consent that this change becomes part of alphaTab under it's current or any future open source license
  • Changes are implemented
  • Existing builds tests pass
  • New tests were added

Further details

  • This is a breaking change
  • This change will require update of the documentation/website

@allandiego
Fix: allow the import of gpx files that use displayScale as Float xml…
3efa524 
… node instead Double

Fix the import of some gpx files that uses <Float>instead <Double> node on XProperties

Example
```xml
<Bar id="29">
  <Clef>G2</Clef>
  <Voices>26 -1 -1 -1</Voices>
  <XProperties>
    <XProperty id="1124139520">
      <Float>1.07818</Float>
    </XProperty>
  </XProperties>
</Bar>
```
@allandiego
Merge branch 'CoderLine:develop' into develop
8dc5c4a
@allandiego
fix: Add support for non-mandatory tags in Section parse
caadb1e 
Adds support for xml Section parsing where sometimes some child tags may not exist, like in this example where only Text child tag is present

```xml
<Section><Text><![CDATA[Pre-Chorus]]></Text></Section>
```
@Danielku15
Copy link
Member

@allandiego Thanks for reporting and providing a fix. Can you also add a quick unit test (e.g. by removing most tracks and bars from the provided file)?

@Danielku15 Danielku15 added the state-stale Reporter is not responding anymore. label Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
state-stale Reporter is not responding anymore.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Xml Section parse error while some child tags may not exist
2 participants
@allandiego @Danielku15