chore: add phpstan #299
Merged
chore: add phpstan #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
HardeepAsrani
approved these changes
Oct 16, 2023
There was a problem hiding this comment.
@Soare-Robert-Daniel LGTM, one thing I'd recommend you to confirm that because of the platform version change, PHPCS still records any issues that might be caused in PHP 5.6 but not 7.4 as our minimum PHP version support is still in 5.6
|
@HardeepAsrani, I set the phpcs at 5.6 level. This should check for errors independently of the platform version. |
|
@Soare-Robert-Daniel Tested and everything's fine here 🚀 |
|
🎉 This PR is included in version 1.2.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
pirate-bot
added
the
released
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add PHPStan for code quality.
Test instructions
Check if everything is working fine.
Closes #297