Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding PHPStan #297

Closed
HardeepAsrani opened this issue Oct 10, 2023 · 1 comment · Fixed by #299
Closed

Adding PHPStan #297

HardeepAsrani opened this issue Oct 10, 2023 · 1 comment · Fixed by #299
Assignees
@Soare-Robert-Daniel
Labels
new feature Request for a new feature or functionality to be added to the project. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.

Comments

@HardeepAsrani
Copy link
Member

HardeepAsrani commented Oct 10, 2023 •
edited
Loading

What problem does this address?

To prevent silly errors like #296, we can introduce PHPStan to the project and catch these in the dev process. We can attempt to have at least Level 3 and possibly Level 5 if it doesn't require major changes.

What is your proposed solution?

Introducing PHPStan (including GH Action) similar to Neve & Otter.

Will this feature require documentation? (Optional)

None
@HardeepAsrani HardeepAsrani added the new feature Request for a new feature or functionality to be added to the project. label Oct 10, 2023
@Soare-Robert-Daniel Soare-Robert-Daniel mentioned this issue Oct 13, 2023
Merged
@Soare-Robert-Daniel Soare-Robert-Daniel linked a pull request Oct 13, 2023 that will close this issue
chore: add phpstan #299
Merged
@Soare-Robert-Daniel Soare-Robert-Daniel added the small (1-3h) This label is used for issues that can be completed within 3 hours or less. label Oct 13, 2023
@pirate-bot
Copy link
Collaborator

🎉 This issue has been resolved in version 1.2.5 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Oct 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Soare-Robert-Daniel Soare-Robert-Daniel

Labels
new feature Request for a new feature or functionality to be added to the project. released Indicate that an issue has been resolved and released in a particular version of the product. small (1-3h) This label is used for issues that can be completed within 3 hours or less.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: add phpstan Codeinwp/templates-patterns-collection
4 participants
@HardeepAsrani @cristian-ungureanu @Soare-Robert-Daniel @pirate-bot