New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

omniauth: prevent sending a verification email #148

Merged

basicavisual merged 1 commit into main from patch-147

Nov 3, 2023

Commits on Nov 3, 2023

omniauth: prevent sending a verification email

`omniauth_registrations_controller.rb` fails to create an account when
the provider doesn't include a required field. This results in the form
being re-rendered leading to a second `#create` call and the creation of
a new `request.env`, causing the loss of data populated by OAuth and
triggering an email confirmation.

See: https://github.com/decidim/decidim/blob/release/0.26-stable/decidim-core/app/commands/decidim/create_omniauth_registration.rb#L75

This patch relies on the `params` to get the `verified_email`.

Closes: #147

samanera committed Nov 3, 2023