omniauth: prevent sending a verification email #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`omniauth_registrations_controller.rb` fails to create an account when the provider doesn't include a required field. This results in the form being re-rendered leading to a second `#create` call and the creation of a new `request.env`, causing the loss of data populated by OAuth and triggering an email confirmation. See: https://github.com/decidim/decidim/blob/release/0.26-stable/decidim-core/app/commands/decidim/create_omniauth_registration.rb#L75 This patch relies on the `params` to get the `verified_email`. Closes: #147
|
Screenshot with the email field removed: 
|
basicavisual
approved these changes
Nov 3, 2023
ghost
deleted the
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
omniauth_registrations_controller.rbfails to create an account when the provider doesn't include a required field. This results in the form being re-rendered leading to a second#createcall and the creation of a newrequest.env, causing the loss of data populated by OAuth and triggering an email confirmation.See: https://github.com/decidim/decidim/blob/release/0.26-stable/decidim-core/app/commands/decidim/create_omniauth_registration.rb#L75
This patch relies on the
paramsto get theverified_email.Closes: #147