-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
597: Accept or Decline Cookies #635
597: Accept or Decline Cookies #635
Conversation
Create UI component for users to accept or decline cookies in their Web browser.
@CodeWritingCow is attempting to deploy a commit to the Clean and Green Philly Team on Vercel. A member of the Team first needs to authorize it. |
Add link to footer. Update footer styling to match new UX requirements. Center align footer elements and separate them with dash symbols.
@thansidwell take a look? |
@nlebovits How do I take a look? Usually there's a post with a Preview link. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
I just approved the preview link, but @CodeWritingCow this is still a draft PR, is it ready for review? |
Yeah, the cookie banner doesn't show up in the Preview. |
@brandonfcohen1 it's not ready for review yet. I've built a UI component for the banner. However, I still need to write the actual logic for allowing/disabling cookies. I'll change the PR status to "ready for review" once it's ready. |
Add padding to match wireframe.
Use Link so state will persist when user navigates to linked page.
Use Next.js Link so cookie state will persist when user navigates to linked pages.
@thansidwell @nlebovits can you review and approve please? |
Add shouldAllowCookies, setShouldAllowCookies to CookieProvider.
If user clicks Save Property button after declining cookies, display cookie-consent banner again.
@bacitracin @thansidwell can you review this PR when you get a chance? Thank you! |
Rewrite parts of click handler into helper methods.
Description
This PR creates a cookie consent banner for users to accept or decline cookies in their Web browser.
When user declines cookies and then clicks the "Save Property" button, the property won't be saved. Instead, the cookie-consent banner will appear again and ask for their permission to save cookies in their browser.
Closes #597
Screenshots
Desktop view
Mobile view
Screen recordings
These videos show 3 of the scenarios where the cookie-consent banner will appear:
1) User visits homepage for the first time
2) User clicks "Cookie Settings" in footer
Screen.Recording.2024-05-28.at.11.50.53.PM.01.edited.mov
3) User clicks "Save Property" button after declining cookies
Screen.Recording.2024-05-28.at.11.50.53.PM.02.edited.mov