Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Cookie banner reappears after user accepts cookies #701

Closed
CodeWritingCow opened this issue Jun 21, 2024 · 2 comments
Closed

Bug: Cookie banner reappears after user accepts cookies #701

CodeWritingCow opened this issue Jun 21, 2024 · 2 comments
Assignees
Labels
bug Something isn't working javascript

Comments

@CodeWritingCow
Copy link
Collaborator

Describe the bug
After a user accepts cookies on the Clean & Green website, the cookie consent banner still appears whenever the user opens the site in a new browser window or tab.

To Reproduce

  1. Go to https://www.cleanandgreenphilly.org.
  2. Click on 'Accept' button in the cookie consent banner at the bottom of the screen.
  3. Open a new browser window or tab, then go to https://www.cleanandgreenphilly.org.
  4. Cookie banner will appear at the bottom of the screen in the new tab/window.

Expected behavior
If a user accepts having cookies on the website, and opens the site in a new browser window or tab, the cookie consent banner should not reappear.

Screenshots
Here is a screen recording of the bug:

cookie.consent.banner.mov

Desktop

  • OS: macOS
  • Browser: Google Chrome and Safari
  • Version: Chrome 126.0.6478.62, Safari 17.5

Additional context
This bug is related to Pull Request #635.

@CodeWritingCow CodeWritingCow changed the title Cookie banner reappears after user accepts cookies Bug: Cookie banner reappears after user accepts cookies Jun 21, 2024
@CodeWritingCow CodeWritingCow added bug Something isn't working javascript labels Jun 21, 2024
@CodeWritingCow CodeWritingCow moved this from Backlog to To Do in Clean & Green Philly Jun 22, 2024
@JT0Y
Copy link

JT0Y commented Jun 22, 2024

Greetings and salutations-
Could I take a whack at this and get this assigned to me? I was looking through the code and it looks like we aren't using local storage here. I have some test code that I can cleanup and further test if we are okay with that implementation.

@CodeWritingCow
Copy link
Collaborator Author

@JT0Y it's yours!

@CodeWritingCow CodeWritingCow moved this from To Do to In Development in Clean & Green Philly Jun 22, 2024
@CodeWritingCow CodeWritingCow moved this from In Development to In Review in Clean & Green Philly Jun 23, 2024
@CodeWritingCow CodeWritingCow moved this from In Review to On Staging in Clean & Green Philly Jun 25, 2024
@CodeWritingCow CodeWritingCow moved this from On Staging to Live in Clean & Green Philly Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working javascript
Projects
Archived in project
Development

No branches or pull requests

2 participants