-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ft/Removed hard coded content #246
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still don't grok your approach @kelvinkipruto ... but, my current thinking is:
slug
is just another field that can be returned fromgetCollectionBySlug
. No need to do anything special to handle it.- If we need to add a new component, we'll add it to existing page(s).
If there is a situation that necessitates straying away from the above path, let us know.
Update get-in-touch as test case
@kilemensi As mentioned in the call, I don't think it will be possible to remove all hard coded content. The above solution works for situations where the props does not require a key like |
…ca/ui into ft/remove-hard-coded-content
@kilemensi Wow 🤯🤩. Thanks. Let me go through it and see how I should have done it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the changeset @kelvinkipruto ?
|
ooh, no, Let me try fix it. |
Description
This PR intends to remove hard-coded content and move it to CMS
Fixes #242
Type of change
Checklist: