Review lib/index.js for any remaining hard-coded strings

[kilemensi]

Now we have full integration with CMSes, it's time to review and remove all remaining hard-coded strings in code. Specifically, we should comb through lib/index.js.

[kelvinkipruto]

@kilemensi Going through this, and it most of the hard-coded titles are section titles and slugs.

[kilemensi]

@kilemensi Going through this, ...

Correct @kelvinkipruto. Can we move them to their respective sections in the NetlifyCMS?

[kelvinkipruto]

@kilemensi how do you propose we do this? I was thinking of a different collection say Sections then add the title and slug, for each possible section, but then I realised most of them are repeated irregardless of the section they are in, example hero , related-stories, and news-stories,

[kilemensi]

Give me a real example of what you've found @kelvinkipruto and lets discuss it.

[kilemensi]

Making any headway on this @kelvinkipruto ?

[kelvinkipruto]

@kilemensi, I have run into a few issues here. The major one of them is related to hidden fields in Netlify CMS. It looks like they don't appear in the .md file as described here and also some open issues regarding it like this. An example in our case would be here where the hidden fields are not added to the .md file.

[kilemensi]

@kilemensi, I have run into a few issues here. The

Hey @kelvinkipruto.

Before I spend some time looking into that, how're hidden fields related to this current issue?

[kelvinkipruto]

@kilemensi We need to move the hard-coded slugs and titles to the cms as hidden fields.

[kilemensi]

@kilemensi We need to move the hard-coded slugs and titles to the cms as hidden fields.

Do we? Did you try #246 (comment)?

i.e. as long as you include slug in fields array, the getCollectionBySlug method will return the slug as part of the result.

Can you share an example where that doesn't work @kelvinkipruto ?

[kelvinkipruto]

@kilemensi Yes I have tried it. In this case the slug returned will be about since the slug in getCollectionBySlug is derived from the filename. The correct slug should be get-in-touch

[kilemensi]

@kilemensi Yes I have tried it. In ...

I've update #246 to handle this case using get-in-touch as an example @kelvinkipruto

[kelvinkipruto]

@kilemensi Let me have a look

[kilemensi]

@kilemensi Let me have a look

And @kelvinkipruto ?