Make keep_alive configurable in the Web version #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
approved these changes
Jan 4, 2024
There was a problem hiding this comment.
I'm not sure it's necessary since keepalive in fetch has a different meaning https://developer.mozilla.org/en-US/docs/Web/API/fetch#keepalive
OTOH, I can imagine that keepalive in Web API compatible env works as expected, so let's merge since it's a customer decision whether to set the flag or not
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #186. Related to #211 (comment).
KeepAlive was disabled for the web version without the possibility to re-enable it.
Checklist
The changelog and the docs will be updated after #218