Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clickhouse client working with bun js #211

Closed
DeniroBlack opened this issue Nov 22, 2023 · 5 comments
Closed

Clickhouse client working with bun js #211

DeniroBlack opened this issue Nov 22, 2023 · 5 comments
Labels
enhancement New feature or request

Comments

@DeniroBlack
Copy link

Bun js is fasted speed js runtime runner

https://bun.sh/

But client not working. Difference with node in this file

client/dist/connection/node_http_connection.js:19

May be difference in http client

Please fix this in next versions. Or tell please how I may fix this myself

@DeniroBlack DeniroBlack added the bug Something isn't working label Nov 22, 2023
@slvrtrn slvrtrn added enhancement New feature or request and removed bug Something isn't working labels Nov 22, 2023
@slvrtrn
Copy link
Contributor

slvrtrn commented Nov 22, 2023

I am not familiar with this tool. However, I see fetch usage there. Does it work with @clickhouse/client-web?

@DeniroBlack
Copy link
Author

I am not familiar with this tool. However, I see fetch usage there. Does it work with @clickhouse/client-web?

With web version works fine! Thanks!

@slvrtrn slvrtrn closed this as completed Dec 1, 2023
@dsumer
Copy link

dsumer commented Dec 28, 2023

Would love to see this issue being reopened. It's working with the @clickhouse/client-web library, but that means we lose the ability to work with the connection pool and keepAlive feature which is only available in the @clickhouse/client library.

Would be awesome if the @clickhouse/client library would also be compatible with Bun, thank you! :)

@slvrtrn
Copy link
Contributor

slvrtrn commented Dec 28, 2023

@dsumer, I suspect the Node.js version will not work with Bun unless we rewrite it entirely to the fetch API. I think the right approach is to make keep-alive configurable in the web version instead - it will be there after #220.

@slvrtrn
Copy link
Contributor

slvrtrn commented Jan 12, 2024

@dsumer, as 0.2.8 is out, it is now possible to modify Keep-Alive setting for the web version (and it is enabled by default). See the release notes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants