Skill level description #79761
Open
Skill level description #79761
+564
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…into skill_level_description
github-actions
bot
added
<Documentation>
Co-authored-by: Aerin <[email protected]>
github-actions
bot
added
[JSON]
Maddremor
reviewed
Feb 21, 2025
Maddremor
reviewed
Feb 21, 2025
Maddremor
reviewed
Feb 21, 2025
github-actions
bot
added
the
BasicBuildPassed
|
Change "you likely have a PhD" to "You would probably have a PhD if the universities weren't full of zombies" perhaps. |
TheShadowFerret
suggested changes
Feb 21, 2025
| "level": 5, | ||
| "description": "You can easily craft useful, if junky weapons and armor, but nothing too complex." | ||
| }, | ||
| { "level": 7, "description": "You're can craft even complex objects without fail." }, |
There was a problem hiding this comment.
Suggested change
| { "level": 7, "description": "You're can craft even complex objects without fail." }, | |
| { "level": 7, "description": "You can craft even complex objects without fail." }, |
| "level": 3, | ||
| "description": "You've learned enough to avoid overswinging and falling off balance if you miss." | ||
| }, | ||
| { "level": 5, "description": "Whether self-taught or trained you've learned quite a lot about fighting." }, |
There was a problem hiding this comment.
Suggested change
| { "level": 5, "description": "Whether self-taught or trained you've learned quite a lot about fighting." }, | |
| { "level": 5, "description": "Whether self-taught or trained, you've learned quite a lot about fighting." }, |
| { "level": 1, "description": "You can usually get a decent cut when chopping." }, | ||
| { "level": 3, "description": "You can reliably keep good edge alignment when slicing." }, | ||
| { "level": 5, "description": "You're a fairly skilled swordsman." }, | ||
| { "level": 9, "description": "With your skill, In another life you could duel a samurai." } |
There was a problem hiding this comment.
Suggested change
| { "level": 9, "description": "With your skill, In another life you could duel a samurai." } | |
| { "level": 9, "description": "With your skill, in another life you could duel a samurai." } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Long time ago someone proposed to move what we have in https://github.com/CleverRaven/Cataclysm-DDA/blob/master/doc/design-balance-lore/GAME_BALANCE.md#skill-system-scaling to a game in some way
Describe the solution
Implement two fields, that allow to define a message, that would allow the player to clearly understand at what point they are with this skill
Describe alternatives you've considered
Not doing it?
Testing