Migrate some worn containers to normal containers

[Holli-Git]

Summary

Bugfixes "Change some worn containers to wielded containers"

Purpose of change

Since we're able to wield stuff with pockets, there's no reason to still have items you "wear" to act as a pocket and not wield it.

Describe the solution

Makes them regular containers, or just removes them in the case of plastic shopping bag and swag bag.

Describe alternatives you've considered

Not doing this

Testing

Loaded up, works fine. Migrating/changing worn items works fine, you just end up wearing the non-wearable item.

Additional context

[mx-moonling]

The idea behind them is they're bags you can carry while holding something else in your hands.
A grocery bag can be put over your shoulder while carrying something else, even if it's very encumbering.

You could argue that the suitcases would be better implemented once you can hold items with each hand, but grocery bags being wearable seems very reasonable to me.

If you're using grocery bags for storage, being able to easily transport multiple at a time seems like a good and realistic feature.

And from a gameplay point of view, the ability to transport multiple of these items is important to innawoods & sky island playthroughs. Large wicker baskets being wearable was a choice made in #79649.

[Holli-Git]

The idea behind them is they're bags you can carry while holding something else in your hands. A grocery bag can be put over your shoulder while carrying something else, even if it's very encumbering.

Some of these items like the plastic shopping bag are really really old. Likely over a decade old, as git blame fails. Wouldn't surprise me if it was in the OG Cataclysm. The idea wasn't to be able to wield a container and also wear one, it was a hacky solution to allow you to "wield" an item with storage before pockets were implemented.

You could argue that the suitcases would be better implemented once you can hold items with each hand, but grocery bags being wearable seems very reasonable to me.

If you're using grocery bags for storage, being able to easily transport multiple at a time seems like a good and realistic feature.

My issue here is that you could argue any pocket should be able to be worn. Should canvas bags be wearable? Plastic sacks? What about ziploc bags? It's much easier to draw the line at "You can't", rather than try to find a vague middle ground.

And from a gameplay point of view, the ability to transport multiple of these items is important to innawoods & sky island playthroughs. Large wicker baskets being wearable was a choice made in #79649.

Hauling already exists to allow you to move with you large amounts of items. And yes, it being wearable was a choice. But due to how it works, it takes up both of your hands, disallowing you to wield anything. What difference does that make between just wielding it? I can't think of any reason.

[XygenSS]

My issue here is that you could argue any pocket should be able to be worn. Should canvas bags be wearable? Plastic sacks? What about ziploc bags? It's much easier to draw the line at "You can't", rather than try to find a vague middle ground.

None of those examples have a carrying handle, a shopping bag or basket you can suspend on your wrist or hang from your armpit or shoulder if you need to use both hands (and despite that, we correctly disallow two-handed actions while you are wearing one, so it doesn't let you do anything illogical).

[Holli-Git]

None of those examples have a carrying handle, a shopping bag or basket you can suspend on your wrist or hang from your armpit or shoulder if you need to use both hands.

Fair point. Still, it feels like a very hacky solution to me

[mx-moonling]

How would you want to see the ability to carry 3 grocery bags at once implemented? Obviously it would be very encumbering and not advisable, but if they aren't too heavy it's definitely doable to have one on each shoulder, and one in your hands, and I don't see a way to express it in the game without some being worn.

[Holli-Git]

How would you want to see the ability to carry 3 grocery bags at once implemented? Obviously it would be very encumbering and not advisable, but if they aren't too heavy it's definitely doable to have one on each shoulder, and one in your hands, and I don't see a way to express it in the game without some being worn.

Have multi-wield be a thing and allow multiple items wielded at the same time.

[XygenSS]

Briefcases and violin cases can be normal containers, since they can't be worn around the arm or shoulder
Suitcases could be a deployable vehicle since you grab and drag it like a shopping cart, but that also feels very clunky.

[mx-moonling]

I think holding multiple grocery bags in one hand would be a lot harder than just putting one on your shoulder, and that it doesn't express the same action or scenario.

[past-simple]

Everyone here knows this, but 'wearing' a bag that restricts one hand is a workaround for the lack of dual wielding. I'm sure any future implementation of dual wielding would rework these items, but for now it's the only way to simulate carrying something in the off hand (e.g. a swag bag gripped around the neck of the bag, or a shopping bag gripped by its handle, or a suitcase gripped by its handle) while also carrying something in the main hand.

[Kilvoctu]

Not sure I understand the reasoning behind the Purpose of change.
If the definition of worn is to have the item on your body while your hands are free, many of these are definitely wearable. I do this in real life all the time with the bags and baskets. Violin cases and briefcases generally come with straps so they can be worn over the shoulder.

For the bindle, and the medium and large suitcase, I have no problem with their migration.
This is all under the assumption that multi-wield will be a thing. In my opinion, these type of migrations would happen after the respective feature is added, though..

[github-actions]

It appears you modified a .po or .pot file. These translation files are automatically generated, pushed to, and pulled from Transifex, and should not be modified otherwise. If these changes are intended, please add Translation file changes are intended to the PR body.

[Holli-Git]

...and it seems I horribly messed this up. No clue how to fix this, I'm opening a new PR soon