Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update custom_gloves.json #79603

Merged
merged 4 commits into from
Feb 10, 2025
Merged

Update custom_gloves.json #79603

merged 4 commits into from
Feb 10, 2025

Conversation

Minemoder234
Copy link
Contributor

@Minemoder234 Minemoder234 commented Feb 8, 2025

Heading

Regarding #79530

Summary

None

Describe the solution

Changed "gloves_h20survivor_thick" name to satisfy issue

Hi!

This is my first time doing a pull request, or really using GitHub to do anything other than download games. If you have any suggestions for a beginner like myself, that would be much appreciated.

Changed "gloves_h20survivor_thick" description to satisfy : CleverRaven#79530
Copy link
Contributor

github-actions bot commented Feb 8, 2025

You are creating a pull request with the master branch as the head branch. This is completely fine if you plan to make contribution once or do not plan to do it often, but if you are interested in making multiple pull requests within a short span of time, this would prevent you from doing it comfortably. You may read https://docs.github.com/en/get-started/quickstart/contributing-to-projects#creating-a-branch-to-work-on for a typical workflow of contributing to a project on GitHub.

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing new contributor labels Feb 8, 2025
@github-actions github-actions bot added json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 8, 2025
"copy-from" doesnt copy names, oops
didnt re-add the "thick" to the names
@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 10, 2025
@GuardianDll GuardianDll merged commit e70f37c into CleverRaven:master Feb 10, 2025
27 of 29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions new contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants