Audit Overmap Terrains for correct application of Riot Damage #79593
+245
−169
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "Audit Overmap Terrains for correct application of Riot Damage"
Purpose of change
Fix #79587. A number of non-city maps are being affected by riot damage. Additionally a number of in-city maps are incorrectly being spared from riot damage.
Describe the solution
Go over just about every file in the overmap terrain folder and one by one add or delete the flag.
Specials spawning in cities should all have the flag now. Specials spawning outside of cities should have the flag deleted from their terrain.
In the case of terrains used in both:
All motels currently generate riot damage. I could be miss-reading this but it looks like the same terrains are used for the in-city special as the out of city special. It's a bit of a confusing web so I left the flag on all motels.
I was able to separate out the rural gas station so it won't have the flag applied to itself.
Some map specials make use of parking lots and s lots. I am not crazy enough to try and untangle that whole mess so for now the majority of parking lots are excluded from the flag. (The mine and sugar house notably).
FEMA camps were specifically included in the riot damage flag as the only map special I deliberately added it to. In my mind there would likely be rioting there as well in the final days. Or at the very least chaos on par with rioting.
Describe alternatives you've considered
Not adding the flag to FEMA camps.
Trying to untangle all instances of parking lots used in map specials to separate them from parking lots in city specials.
Removing the copy from on some map specials that are clearly not in city buildings.
Testing
Loaded up a new world. Teleported around to the locations, verifying behavior as expected. Map specials were not rioted. City Specials are.
I did notice it behaves erratically when Nested Mapgen is used. Specifically the strip mall totally overwrites the riot damage and it is never applied to the nested chunk. Something to look out and bug report I guess.
Additional context