Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Implement riot damage in cities" #79580

Closed
wants to merge 1 commit into from

Conversation

ZhilkinSerg
Copy link
Contributor

@ZhilkinSerg ZhilkinSerg commented Feb 7, 2025

Summary

None

Purpose of change

Reverts #79535
Fixes #79565

Additional context

Map post-processing is a very nice feature to have and it just needs to be implemented properly next time, but let's revert it for now.

@github-actions github-actions bot added <Documentation> Design documents, internal info, guides and help. [JSON] Changes (can be) made in JSON Map / Mapgen Overmap, Mapgen, Map extras, Map display [C++] Changes (can be) made in C++. Previously named `Code` Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [Markdown] Markdown issues and PRs json-styled JSON lint passed, label assigned by github actions astyled astyled PR, label is assigned by github actions labels Feb 7, 2025
@ashGlaw
Copy link
Contributor

ashGlaw commented Feb 7, 2025

I absolutely love the feature, but I agree that it hasn't been implemented as well as it could've been. Taking it out probably is the simplest fix for now, though I hope it doesn't end up on the cutting room floor forever.

@KheaHyena
Copy link

Same, it's a very neat implementation, but it's frequency (not exactly due to the issues of being run multiples times) was a tad high. I'd imagine some places wouldn't be targets of looting and violence (specially when not populated at all, or far from bigger cities, such as the miniature railroads).
Although my biggest concern was how consistent the fire wanted to appear, upping up the chaos (which is both a nice and bad thing, one could say). I suppose apartments would be a huge wreck, but I didn't explore them so I cannot comment how the implementation worked in those. The fire itself though, liked to appear even in silly places like sidewalks and roads.

@Daved27hundred
Copy link
Contributor

I absolutely love the feature, but I agree that it hasn't been implemented as well as it could've been. Taking it out probably is the simplest fix for now, though I hope it doesn't end up on the cutting room floor forever.

ditto. This bug also gave me a funny mental image of a bunch of ferals trashing the save file whenever you close the game.

@github-actions github-actions bot added the BasicBuildPassed This PR builds correctly, label assigned by github actions label Feb 7, 2025
@GuardianDll
Copy link
Member

#79575 resolved the error, so i do not see a reason to remove generator anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions BasicBuildPassed This PR builds correctly, label assigned by github actions [C++] Changes (can be) made in C++. Previously named `Code` <Documentation> Design documents, internal info, guides and help. Fields / Furniture / Terrain / Traps Objects that are part of the map or its features. [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions Map / Mapgen Overmap, Mapgen, Map extras, Map display [Markdown] Markdown issues and PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Implement riot damage in cities" is run again every single time a save is loaded
5 participants