-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Military Seabags #79465
base: master
Are you sure you want to change the base?
Add Military Seabags #79465
Conversation
Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details. Click to expand
This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to Hints for adding a new word to the dictionary
|
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Good add 👍 |
fyi you should not only add the bag, you should also add it to different itemgroups so it's actually possible to find one |
Summary
Content "Add seabags, a large duffel used by the military when traveling"
Purpose of change
Couldn't find a good analog to this common military bag. The high volume rucksack or dry duffel bag were the closest, but the rucksack has more pockets, is heavier, and generally has a different "feel", and the dry duffel bag is too small
Describe the solution
Add my own based on the dry duffel bag and measurements from an online surplus store
Describe alternatives you've considered
Using one of the existing bags, but decided this one was both different, and common enough to warrant its own item
Testing
Loaded into the game with the changes, corrected a few typos. Ended up getting an error about it being bigger on the inside, but i'm not sure why since it shouldn't be rigid.
FUNCTION : check_definitions
Additional context
Based on the USMC seabag, as pictured here:
![image](https://private-user-images.githubusercontent.com/26364270/408753926-f55095e8-f5ed-4f5f-82c1-08a919127986.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxODk3NzAsIm5iZiI6MTczOTE4OTQ3MCwicGF0aCI6Ii8yNjM2NDI3MC80MDg3NTM5MjYtZjU1MDk1ZTgtZjVlZC00ZjVmLTgyYzEtMDhhOTE5MTI3OTg2LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTAlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjEwVDEyMTExMFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWU2YjBhZTRjZjljZTFmYjQ0ZjBlOGZiYmQ0MGZmYTY3NmY5OWU4ZWRhZjgyODhjMTE0NGM0OGQ4NGMyOWZjNDImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.rz-mpWrhkApIqIDayTV91-dRQu9eqndX783wQ1jR6Yc)