Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Military Seabags #79465

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

Comrade-Soupbeans
Copy link
Contributor

Summary

Content "Add seabags, a large duffel used by the military when traveling"

Purpose of change

Couldn't find a good analog to this common military bag. The high volume rucksack or dry duffel bag were the closest, but the rucksack has more pockets, is heavier, and generally has a different "feel", and the dry duffel bag is too small

Describe the solution

Add my own based on the dry duffel bag and measurements from an online surplus store

Describe alternatives you've considered

Using one of the existing bags, but decided this one was both different, and common enough to warrant its own item

Testing

Loaded into the game with the changes, corrected a few typos. Ended up getting an error about it being bigger on the inside, but i'm not sure why since it shouldn't be rigid.

DEBUG : warnings for type seabag:
is bigger on the inside. consider using TARDIS flag.

FUNCTION : check_definitions

Additional context

Based on the USMC seabag, as pictured here:
image

@github-actions github-actions bot added [JSON] Changes (can be) made in JSON Items: Armor / Clothing Armor and clothing astyled astyled PR, label is assigned by github actions labels Jan 31, 2025
Copy link
Contributor

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand
  • Tucked between your back and the seabag.
  • military seabag
  • military seabags

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary
  • If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
  • For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

Comrade-Soupbeans and others added 5 commits January 31, 2025 18:43
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot added the json-styled JSON lint passed, label assigned by github actions label Feb 1, 2025
@ashGlaw
Copy link
Contributor

ashGlaw commented Feb 1, 2025

Good add 👍

@GuardianDll
Copy link
Member

fyi you should not only add the bag, you should also add it to different itemgroups so it's actually possible to find one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
astyled astyled PR, label is assigned by github actions Items: Armor / Clothing Armor and clothing [JSON] Changes (can be) made in JSON json-styled JSON lint passed, label assigned by github actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants