LIIKUNTA-582, LIIKUNTA-585 | feat: add hierarchical menus & universal bar menu support to Navigation #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karisal-anders
changed the title
karisal-anders
force-pushed
the
LIIKUNTA-582-extend-header-menus
branch
2 times, most recently
from
3cab750 to
aa71ea3
Compare
karisal-anders
added a commit
to City-of-Helsinki/events-helsinki-monorepo
that referenced
this pull request
Nov 18, 2023
uses canary build of HCRC from City-of-Helsinki/react-helsinki-headless-cms#138 refs LIIKUNTA-582 (add support for hierarchical menus in header) refs LIIKUNTA-585 (add support for universal bar menu in header)
karisal-anders
added a commit
to City-of-Helsinki/events-helsinki-monorepo
that referenced
this pull request
Nov 20, 2023
uses canary build of HCRC from City-of-Helsinki/react-helsinki-headless-cms#138 refs LIIKUNTA-582 (add support for hierarchical menus in header) refs LIIKUNTA-585 (add support for universal bar menu in header)
melniiv
reviewed
Nov 20, 2023
src/core/navigation/Navigation.tsx
Outdated
| }; | ||
|
|
||
| const LOGO_ARIA_LABELS = { | ||
| const CITY_OF_HELSINKI_TRANSLATIONS = { |
There was a problem hiding this comment.
we can add those though hcrc config, in copy section we have translations
There was a problem hiding this comment.
Moved this to config:
- LOGO_ARIA_LABELS/CITY_OF_HELSINKI_TRANSLATIONS -> config.translations.cityOfHelsinki
melniiv
reviewed
Nov 20, 2023
| EN: 'City of Helsinki', | ||
| FI: 'Helsingin kaupunki', | ||
| SV: 'Helsingfors stad', | ||
| } as const satisfies Record<LanguageCodeEnum, string>; | ||
|
|
||
| const LOGO_LABELS = { |
There was a problem hiding this comment.
we can add those though hcrc config, in copy section we have translations
There was a problem hiding this comment.
Moved this to config:
- LOGO_LABELS -> config.translations.helsinki
melniiv
reviewed
Nov 20, 2023
src/core/navigation/Navigation.tsx
Outdated
| }; | ||
|
|
||
| const localizedCityOfHelsinki = | ||
| CITY_OF_HELSINKI_TRANSLATIONS[currentLanguageCode]; |
There was a problem hiding this comment.
when translations are added though the config we dont need this code anymore
There was a problem hiding this comment.
Moved this to config:
- CITY_OF_HELSINKI_TRANSLATIONS -> config.translations.cityOfHelsinki
melniiv
approved these changes
Nov 20, 2023
karisal-anders
force-pushed
the
LIIKUNTA-582-extend-header-menus
branch
3 times, most recently
from
c8571d2 to
41b8c9d
Compare
Navigation:
- add support for hierarchical menus
- add support for universal bar menu
- the universal bar menu is shown on the top of the header at least
when using a wide screen
- remove deprecated variant property
queries:
- add parentId to menu query to fetch hierarchy of menus
mocks:
- make navigation mock menu hierarchical
- this hierarchical menu can be seen in storybook's ArchiveSearchPage
- add mock for universal bar menu
packages:
- add crypto-browserify as development dependency to fix running
storybook
- crypto is being used by hds-react since HDS v3
- set version to 1.0.0-alpha230
refs LIIKUNTA-582
karisal-anders
force-pushed
the
LIIKUNTA-582-extend-header-menus
branch
from
41b8c9d to
39d5f3e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
feat: add hierarchical menus & universal bar menu support to Navigation
Navigation:
when using a wide screen
queries:
mocks:
packages:
storybook
refs LIIKUNTA-582
Issues
Closes
Related
LIIKUNTA-582
LIIKUNTA-585
Testing
In PR review environments (if they are working):
Locally:
yarnyarn storybookAutomated tests
Manual testing
Screenshots
Additional notes
Published as canary build [email protected] to npm