Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIIKUNTA-582, LIIKUNTA-585 | feat: add support for hierarchical menus & universal bar menu in header #552

Merged
merged 1 commit into from
Nov 21, 2023
Merged

LIIKUNTA-582, LIIKUNTA-585 | feat: add support for hierarchical menus & universal bar menu in header #552

merged 1 commit into from
Nov 21, 2023

Conversation

karisal-anders
Copy link
Contributor

@karisal-anders karisal-anders commented Nov 18, 2023 •
edited
Loading

Description

feat: add support for hierarchical menus & universal bar menu in header

refs LIIKUNTA-582 (add support for hierarchical menus in header)
refs LIIKUNTA-585 (add support for universal bar menu in header)

Issues

Closes

LIIKUNTA-582
LIIKUNTA-585

Related

Testing

  • Check out PR's branch locally
  • yarn
  • cd apps/sports-helsinki
    • set local variables in .env.local
      • NEXT_PUBLIC_CMS_HEADER_UNIVERSAL_BAR_MENU_NAME_FI="Sports Helsinki Universal bar FI"
      • NEXT_PUBLIC_CMS_HEADER_UNIVERSAL_BAR_MENU_NAME_EN="Sports Helsinki Universal bar EN"
      • NEXT_PUBLIC_CMS_HEADER_UNIVERSAL_BAR_MENU_NAME_SV="Sports Helsinki Universal bar SV"
    • yarn dev

Automated tests

Manual testing

Screenshots

image

image

image

image

image

image

image

image

Additional notes

@karisal-anders karisal-anders mentioned this pull request Nov 18, 2023
Merged
@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr552.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr552.dev.hel.ninja 🚀🚀🚀

@karisal-anders karisal-anders force-pushed the LIIKUNTA-582-use-menu-hierarchy branch from c101644 to 8c2062f Compare November 20, 2023 09:07
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr552.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr552.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

EVENTS GRAPHQL PROXY is deployed to platta: https://events-graphql-proxy-pr552.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

VENUE GRAPHQL PROXY is deployed to platta: https://venue-graphql-proxy-pr552.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr552.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr552.dev.hel.ninja 😆🎉🎉🎉

@karisal-anders
feat: add support for hierarchical menus & universal bar menu in header
6273690 
refs LIIKUNTA-582 (add support for hierarchical menus in header)
refs LIIKUNTA-585 (add support for universal bar menu in header)
@karisal-anders karisal-anders force-pushed the LIIKUNTA-582-use-menu-hierarchy branch from 8c2062f to 6273690 Compare November 21, 2023 09:29
@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@sonarqubecloud SonarQubeCloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@terovirtanen
Copy link
Contributor

Sports-Helsinki branch is deployed to platta: https://liikunta-pr552.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

Events-Helsinki branch is deployed to platta: https://tapahtumat-pr552.dev.hel.ninja 🚀🚀🚀

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://liikunta-pr552.dev.hel.ninja 😆🎉🎉🎉

@terovirtanen
Copy link
Contributor

TestCafe result is success for https://tapahtumat-pr552.dev.hel.ninja 😆🎉🎉🎉

@karisal-anders karisal-anders merged commit 318d409 into main Nov 21, 2023
60 of 73 checks passed
@karisal-anders karisal-anders deleted the LIIKUNTA-582-use-menu-hierarchy branch November 21, 2023 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@melniiv melniiv melniiv approved these changes

@nikomakela nikomakela Awaiting requested review from nikomakela

@jakezu jakezu Awaiting requested review from jakezu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karisal-anders @terovirtanen @melniiv