Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional effects and meta/post effects #57

Merged
merged 10 commits into from
Dec 29, 2024
Merged

Conditional effects and meta/post effects #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
43d39bb
feat: initial conditional meta effect prototyping
Chillu1 Dec 14, 2024
a88ebee
feat: value comparison, heal & dmg condition meta effect logic
Chillu1 Dec 15, 2024
67a14ff
feat: multi meta effect conditions
Chillu1 Dec 15, 2024
a6b7760
feat: generic conditions, condition post efefct
Chillu1 Dec 15, 2024
21b451f
feat: generic condition effect
Chillu1 Dec 15, 2024
e5e2bbe
feat: initial effect condition testing
Chillu1 Dec 24, 2024
892f2e0
feat: more condition effect brainstorming and testing
Chillu1 Dec 29, 2024
f6182d5
feat: remove inheritance condition effect impl
Chillu1 Dec 29, 2024
2d63db9
feat: condition debuff effect
Chillu1 Dec 29, 2024
1cbe2f9
feat: and or conditions
Chillu1 Dec 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
173 changes: 173 additions & 0 deletions ModiBuff/ModiBuff.Tests/MetaEffectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,5 +137,178 @@ public void ConditionalEffectsBasedOnManaUsage()
Assert.AreEqual(EnemyHealth - 2 - 1.5 - 1, Enemy.Health);
Assert.AreEqual(0, Unit.Mana);
}

[Test]
public void ReverseValueOnFullHealthMetaEffectCondition()
{
AddRecipe("InitHealValueBasedOnStatMeta")
.Effect(new HealEffect(5)
.SetMetaEffects(new ReverseValueMetaEffect()
.Condition(new ValueFull(StatTypeCondition.Health))),
EffectOn.Init);
Setup();

Unit.AddModifierSelf("InitHealValueBasedOnStatMeta");
Assert.AreEqual(UnitHealth - 5, Unit.Health);
Unit.AddModifierSelf("InitHealValueBasedOnStatMeta");
Assert.AreEqual(UnitHealth, Unit.Health);
}

[Test]
public void ReverseValueOnNotFullHealthMetaEffectCondition()
{
AddRecipe("InitDamageValueBasedOnStatMeta")
.Effect(new DamageEffect(5)
.SetMetaEffects(new ReverseValueMetaEffect()
.Condition(new ValueFull(StatTypeCondition.Health, true))),
EffectOn.Init);
Setup();

Unit.AddModifierSelf("InitDamageValueBasedOnStatMeta");
Assert.AreEqual(UnitHealth - 5, Unit.Health);
Unit.AddModifierSelf("InitDamageValueBasedOnStatMeta");
Assert.AreEqual(UnitHealth, Unit.Health);
}

[Test]
public void ReverseValueOnNotFullHealthAndHigherThanHalfMetaEffectCondition()
{
AddRecipe("InitDamageValueBasedOnStatMeta")
.Effect(new HealEffect(5)
.SetMetaEffects(new ReverseValueMetaEffect().Condition(
new ValueFull(StatTypeCondition.Health, true),
new ValueComparisonPercent(StatType.Health, ComparisonType.GreaterOrEqual, 0.5f))),
EffectOn.Init);
Setup();

Unit.TakeDamage(5, Unit);

Unit.AddModifierSelf("InitDamageValueBasedOnStatMeta");
Assert.AreEqual(UnitHealth - 5 - 5, Unit.Health);

Unit.TakeDamage(UnitHealth / 2f, Unit);
Unit.AddModifierSelf("InitDamageValueBasedOnStatMeta");
Assert.AreEqual(UnitHealth - 5 - 5 - UnitHealth / 2f + 5, Unit.Health);
}

[Test]
public void ReversePoisonDamageValueOnNotFullHealthMetaEffectCondition()
{
AddRecipe("PoisonValueBasedOnNotFullHealthMeta")
.Stack(WhenStackEffect.Always)
.Effect(new PoisonDamageEffect().SetMetaEffects(new ReverseValueMetaEffect()
.Condition(new ValueFull(StatTypeCondition.Health, true))),
EffectOn.Interval | EffectOn.Stack)
.Interval(1)
.Remove(5).Refresh();
Setup();


Unit.AddModifierSelf("PoisonValueBasedOnNotFullHealthMeta");
Unit.Update(1);
Assert.AreEqual(UnitHealth - 5, Unit.Health);

Unit.Update(1);
Assert.AreEqual(UnitHealth, Unit.Health);
}


[Test]
public void MetaEffectWithConditionalEffect()
{
AddRecipe("DamageAddFlatOnRooted")
.Effect(new DamageEffect(5)
.SetMetaEffects(
new AddValueMetaEffect(5).Condition(new StatusEffectCond(StatusEffectType.Root))
),
EffectOn.Init);
Setup();

Unit.AddModifierSelf("DamageAddFlatOnRooted");
Assert.AreEqual(UnitHealth - 5, Unit.Health);

Unit.ChangeStatusEffect(StatusEffectType.Root, 1, Unit);
Unit.AddModifierSelf("DamageAddFlatOnRooted");
Assert.AreEqual(UnitHealth - 5 - 10, Unit.Health);

Unit.Update(1);

Unit.ChangeStatusEffect(StatusEffectType.Disarm, 1, Unit);
Unit.AddModifierSelf("DamageAddFlatOnRooted");
Assert.AreEqual(UnitHealth - 5 - 10 - 5, Unit.Health);
}

[Test]
public void MultipleConditionalMetaEffectsWithTwoConditionalEffects()
{
var metaEffects = new IMetaEffect<float, float>[]
{
new AddValueMetaEffect(5).Condition(new StatusEffectCond(StatusEffectType.Root)),
new MultiplyValueMetaEffect(2).Condition(new StatusEffectCond(StatusEffectType.Silence))
};
AddRecipe("AddFlatOnRooted_MultiplyOnSilenced_HealOnDisarmed")
.Effect(new DamageEffect(5)
.Condition(new StatusEffectCond(StatusEffectType.Disarm, true))
.SetMetaEffects(metaEffects), EffectOn.Init)
.Effect(new HealEffect(5)
.Condition(new StatusEffectCond(StatusEffectType.Disarm))
.SetMetaEffects(metaEffects), EffectOn.Init);
Setup();

Unit.AddModifierSelf("AddFlatOnRooted_MultiplyOnSilenced_HealOnDisarmed");
Assert.AreEqual(UnitHealth - 5, Unit.Health);

Unit.ChangeStatusEffect(StatusEffectType.Root, 1, Unit);
Unit.AddModifierSelf("AddFlatOnRooted_MultiplyOnSilenced_HealOnDisarmed");
Assert.AreEqual(UnitHealth - 5 - 10, Unit.Health);

Unit.ChangeStatusEffect(StatusEffectType.Silence, 1, Unit);
Unit.AddModifierSelf("AddFlatOnRooted_MultiplyOnSilenced_HealOnDisarmed");
Assert.AreEqual(UnitHealth - 5 - 10 - 20, Unit.Health);

Unit.ChangeStatusEffect(StatusEffectType.Disarm, 1, Unit);
Unit.AddModifierSelf("AddFlatOnRooted_MultiplyOnSilenced_HealOnDisarmed");
Assert.AreEqual(UnitHealth - 5 - 10 - 20 + 20, Unit.Health);

Unit.Update(1);

Unit.ChangeStatusEffect(StatusEffectType.Disarm, 1, Unit);
Unit.AddModifierSelf("AddFlatOnRooted_MultiplyOnSilenced_HealOnDisarmed");
Assert.AreEqual(UnitHealth - 5 - 10 - 20 + 20 + 5, Unit.Health);
}

[Test]
public void MultipleConditionalMetaEffectsWithAndOr()
{
AddRecipe("AddFlatOnRootedAndSilenced_MultiplyOnDisarmedOrFrozen")
.Effect(new DamageEffect(5)
.SetMetaEffects(
new AddValueMetaEffect(5).Condition(new AndCondition(
new StatusEffectCond(StatusEffectType.Root),
new StatusEffectCond(StatusEffectType.Silence)))
, new MultiplyValueMetaEffect(2).Condition(new OrCondition(
new StatusEffectCond(StatusEffectType.Disarm),
new StatusEffectCond(StatusEffectType.Freeze)
))),
EffectOn.Init)
.Remove(1).Refresh();
Setup();

Unit.AddModifierSelf("AddFlatOnRootedAndSilenced_MultiplyOnDisarmedOrFrozen");
Assert.AreEqual(UnitHealth - 5, Unit.Health);

Unit.ChangeStatusEffect(StatusEffectType.Root, 1, Unit);
Unit.AddModifierSelf("AddFlatOnRootedAndSilenced_MultiplyOnDisarmedOrFrozen");
Assert.AreEqual(UnitHealth - 5 - 5, Unit.Health);
Unit.ChangeStatusEffect(StatusEffectType.Silence, 1, Unit);
Unit.AddModifierSelf("AddFlatOnRootedAndSilenced_MultiplyOnDisarmedOrFrozen");
Assert.AreEqual(UnitHealth - 5 - 5 - 10, Unit.Health);

Unit.Update(1);

Unit.ChangeStatusEffect(StatusEffectType.Freeze, 1, Unit);
Unit.AddModifierSelf("AddFlatOnRootedAndSilenced_MultiplyOnDisarmedOrFrozen");
Assert.AreEqual(UnitHealth - 5 - 5 - 10 - 10, Unit.Health);
}
}
}
40 changes: 40 additions & 0 deletions ModiBuff/ModiBuff.Tests/PostEffectTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,5 +62,45 @@ public void HealTargetDamageSelf()
Assert.AreEqual(EnemyHealth, Enemy.Health);
Assert.AreEqual(UnitHealth - 5, Unit.Health);
}

[Test]
public void ReverseValueOnFullHealthPostEffectCondition()
{
AddRecipe("InitDamageLifestealOnNotFullMana")
.Effect(new DamageEffect(5)
.SetPostEffects(new LifeStealPostEffect(2f)
.Condition(new ValueFull(StatTypeCondition.Mana, true))),
EffectOn.Init);
Setup();

Unit.AddModifierSelf("InitDamageLifestealOnNotFullMana");
Assert.AreEqual(UnitHealth - 5, Unit.Health);
Unit.UseMana(5);
Unit.AddModifierSelf("InitDamageLifestealOnNotFullMana");
Assert.AreEqual(UnitHealth, Unit.Health);
}

[Test]
public void ApplyDoTIfTargetIsFlammablePostEffectCondition()
{
AddRecipe("FlammableDebuff")
.Effect(new DebuffEffect(DebuffType.Flammable), EffectOn.Init)
.Remove(5).Refresh();
AddRecipe("FlamingAttack")
.Effect(new DamageEffect(5), EffectOn.Init)
.Effect(new DamageEffect(2).Condition(new DebuffEffectCond(DebuffType.Flammable)), EffectOn.Interval)
.Interval(1)
.Remove(5).Refresh();
Setup();

Unit.AddModifierSelf("FlamingAttack");
Unit.Update(5);
Assert.AreEqual(UnitHealth - 5, Unit.Health);

Unit.AddModifierSelf("FlammableDebuff");
Unit.AddModifierSelf("FlamingAttack");
Unit.Update(1);
Assert.AreEqual(UnitHealth - 5 - 5 - 2, Unit.Health);
}
}
}
7 changes: 7 additions & 0 deletions ModiBuff/ModiBuff.Units/DebuffType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
namespace ModiBuff.Core.Units
{
public enum DebuffType
{
Flammable = 0,
}
}
Loading
Loading