Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional effects and meta/post effects #57

Merged
merged 10 commits into from
Dec 29, 2024

Conversation

Chillu1
Copy link
Owner

@Chillu1 Chillu1 commented Dec 15, 2024

A better solution to dynamic post/meta effects, by instead using conditional logic on runtime, so no state is needed in the effects or meta/post effects. At the cost of a small performance penalty.

Issues/Design choices:

  • Should effects store meta condition effects separately? To not type/null check the conditional/non-conditional ones.
  • Conditions not inferring the inherited type with generics, forcing more boilerplate code when adding conditions.

Closes #41

@Chillu1 Chillu1 changed the title Conditional meta/post effects Conditional effects and meta/post effects Dec 29, 2024
@Chillu1 Chillu1 marked this pull request as ready for review December 29, 2024 19:52
@Chillu1 Chillu1 merged commit 299760c into master Dec 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dynamic Meta/Post effects
1 participant