Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update(query): update App Service Not Using Latest TLS Encryption Version query to the latest version #7302

Merged
merged 4 commits into from
Jan 17, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
@@ -7,20 +7,20 @@ CxPolicy[result] {
app := input.document[i].resource.azurerm_app_service[name]

is_number(app.site_config.min_tls_version)
app.site_config.min_tls_version != 1.2
app.site_config.min_tls_version != 1.3

result := {
"documentId": input.document[i].id,
"resourceType": "azurerm_app_service",
"resourceName": tf_lib.get_resource_name(app, name),
"searchKey": sprintf("azurerm_app_service[%s].site_config.min_tls_version", [name]),
"issueType": "IncorrectValue",
"keyExpectedValue": sprintf("'azurerm_app_service[%s].site_config.min_tls_version' should be set to '1.2'", [name]),
"keyActualValue": sprintf("'azurerm_app_service[%s].site_config.min_tls_version' is not set to '1.2'", [name]),
"keyExpectedValue": sprintf("'azurerm_app_service[%s].site_config.min_tls_version' should be set to '1.3'", [name]),
"keyActualValue": sprintf("'azurerm_app_service[%s].site_config.min_tls_version' is not set to '1.3'", [name]),
"searchLine": common_lib.build_search_line(["resource", "azurerm_app_service", name, "site_config", "min_tls_version"], []),
"remediation": json.marshal({
"before": sprintf("%.1f", [app.site_config.min_tls_version]),
"after": "1.2"
"after": "1.3"
}),
"remediationType": "replacement",
}
@@ -30,20 +30,20 @@ CxPolicy[result] {
app := input.document[i].resource.azurerm_app_service[name]

not is_number(app.site_config.min_tls_version)
app.site_config.min_tls_version != "1.2"
app.site_config.min_tls_version != "1.3"

result := {
"documentId": input.document[i].id,
"resourceType": "azurerm_app_service",
"resourceName": tf_lib.get_resource_name(app, name),
"searchKey": sprintf("azurerm_app_service[%s].site_config.min_tls_version", [name]),
"issueType": "IncorrectValue",
"keyExpectedValue": sprintf("'azurerm_app_service[%s].site_config.min_tls_version' should be set to '1.2'", [name]),
"keyActualValue": sprintf("'azurerm_app_service[%s].site_config.min_tls_version' is not set to '1.2'", [name]),
"keyExpectedValue": sprintf("'azurerm_app_service[%s].site_config.min_tls_version' should be set to '1.3'", [name]),
"keyActualValue": sprintf("'azurerm_app_service[%s].site_config.min_tls_version' is not set to '1.3'", [name]),
"searchLine": common_lib.build_search_line(["resource", "azurerm_app_service", name, "site_config", "min_tls_version"], []),
"remediation": json.marshal({
"before": sprintf("%s", [app.site_config.min_tls_version]),
"after": "1.2"
"after": "1.3"
}),
"remediationType": "replacement",
}
Original file line number Diff line number Diff line change
@@ -7,6 +7,6 @@ resource "azurerm_app_service" "negative1" {
site_config {
dotnet_framework_version = "v4.0"
scm_type = "LocalGit"
min_tls_version = 1.2
min_tls_version = 1.3
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
resource "azurerm_app_service" "positive2" {
name = "example-app-service"
location = azurerm_resource_group.example.location
resource_group_name = azurerm_resource_group.example.name
app_service_plan_id = azurerm_app_service_plan.example.id

site_config {
dotnet_framework_version = "v4.0"
scm_type = "LocalGit"
min_tls_version = 1.2
}
}
Original file line number Diff line number Diff line change
@@ -4,5 +4,11 @@
"severity": "MEDIUM",
"line": 10,
"fileName": "positive1.tf"
},
{
"queryName": "App Service Not Using Latest TLS Encryption Version",
"severity": "MEDIUM",
"line": 10,
"fileName": "positive2.tf"
}
]