update(query): update App Service Not Using Latest TLS Encryption Version query to the latest version

[anterosilva1985]

Reason for Proposed Changes

• The latest TLS Encryption Version is now 1.3

Proposed Changes

• Change the latest TLS Encryption Version from 1.2 to 1.3

I submit this contribution under the Apache-2.0 license.

[ArturRibeiro-CX]

Hey @anterosilva1985,
Nice contribution and great update to the query! 🎉

To make the test cases more comprehensive and complete, I would suggest the following changes:

1 - Add a positive expected result (positive2.tf) to signal an invalid configuration;
2 - Update positive_expected_result.json with the new expected result added;
3 - Update negative1.tf modifying the file with the new valid encryption level (1.3);

Negative1.tf update suggestion

resource "azurerm_app_service" "negative1" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id

  site_config {
    dotnet_framework_version = "v4.0"
    scm_type                 = "LocalGit"
    min_tls_version = 1.3
  }
}

Additional Positive2.tf result && Updated Positive_expected_result.json suggestion

We could modify the current negative1 file to reflect the new invalid encryption level, such as using a version lower than 1.3 (e.g., encryption: 1.1 and 1.2 with the new query update).
This ensures the query accurately flags cases with unsupported encryption levels and effectively warns new users with the new valid encription level, which needs to be equal or higher than 1.3.

resource "azurerm_app_service" "positive2" {
  name                = "example-app-service"
  location            = azurerm_resource_group.example.location
  resource_group_name = azurerm_resource_group.example.name
  app_service_plan_id = azurerm_app_service_plan.example.id

  site_config {
    dotnet_framework_version = "v4.0"
    scm_type                 = "LocalGit"
    min_tls_version = 1.2
  }
}

Regarding the positive_expected_result file, we could just add a new entry, updating the file as demonstrated below:

[
  {
    "queryName": "App Service Not Using Latest TLS Encryption Version",
    "severity": "MEDIUM",
    "line": 10,
    "fileName": "positive1.tf"
  },
  {
    "queryName": "App Service Not Using Latest TLS Encryption Version",
    "severity": "MEDIUM",
    "line": 10,
    "fileName": "positive2.tf"
  }
]

These are just community suggestions, but they would fix the failing unit tests and, I believe, complete your query update while enhancing the test cases a little bit. 😄
Thanks!

[cx-ruiaraujo]

LGTM