Generic accounts displayed in call info #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tbaut It works well! I have only concerns about how it looks, the data appearance is pretty dense. We need to consider the design for the transaction list improvement story
|
|
Yes, this issue #134 has evolved a bit over time, it used to be for anything, then we changed it for batch specifically. We're already in a better state than where we were. The main issue is to show things nicely, but in a maintainable and generic way. Unordered list were acceptable so far, but we need to do better eventually |
Lykhoyda
approved these changes
Oct 9, 2023
|
I'll wait for #384 to be reviewed before merging, since it'll be harder to review otherwise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #379
Similar to #384 but for addresses and multisigs.
We now will show the identicon, and eventually the name of the address if stored either locally, or in the extension.
The testing is similar as well, you can create some extrinsics on pjs/apps and see the result of the decoding in the new tx > from call data. E.g with batch
Submission checklist: not applicable