Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show address with identicon in Tx review when the param type is an address #379

Closed
Tbaut opened this issue Sep 29, 2023 · 0 comments · Fixed by #392
Closed

Show address with identicon in Tx review when the param type is an address #379

Tbaut opened this issue Sep 29, 2023 · 0 comments · Fixed by #392
Assignees
Labels
Priority: 🟠 P1 Added to issues and PRs relating to a high severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations.

Comments

@Tbaut
Copy link
Collaborator

Tbaut commented Sep 29, 2023

For the review of manual extrinsics, we show the address plainly, without the identicon or a name, e.g
image

There's currently a hack to show it nicely only for balances.transfer alike and proxy.addProxy alike here

const isBalancesTransferAlike = ['balances.transfer', 'balances.transferKeepAlive'].includes(name)
const isProxyCreationDeletion = ['proxy.addProxy', 'proxy.removeProxy'].includes(name)

We should enhance this and check the type of params generically, and show a <AccountDisplay/> which will show the name if any/identity and the identicon.

I didn't do the research to know exactly what types are linked to such fields AccountId, or maybe it AccountIdLookupOf or MultiAddress?

Although this should be checked on Polkadot/Kusama/Rococo first, please check on other networks such as Hydra or Phala. The types may be different because these things evolve.

@Tbaut Tbaut added Priority: 🟡 P2 Added to issues and PRs relating to a medium severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations. labels Sep 29, 2023
@Tbaut Tbaut added Priority: 🟠 P1 Added to issues and PRs relating to a high severity bugs. and removed Priority: 🟡 P2 Added to issues and PRs relating to a medium severity bugs. labels Sep 29, 2023
@Tbaut Tbaut self-assigned this Oct 9, 2023
@Tbaut Tbaut linked a pull request Oct 9, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: 🟠 P1 Added to issues and PRs relating to a high severity bugs. Type: 🫶 Enhancement Added to issues and PRs when a change includes improvements or optimizations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant