squid: abc: Add the AbstractCamera interface, and a simulated camera implementation #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianohara
force-pushed
the
ian/camera-interface
branch
from
4bd7a7b to
166ae9b
Compare
beniroquai
pushed a commit
to beniroquai/octopi-research
that referenced
this pull request
Jan 20, 2025
zaber filter wheel
ianohara
force-pushed
the
ian/camera-interface
branch
2 times, most recently
from
39f19ea to
64fd872
Compare
ianohara
force-pushed
the
ian/camera-interface
branch
from
64fd872 to
5d6dbcb
Compare
ianohara
commented
Feb 18, 2025
software/squid/camera/utils.py
Outdated
| _log = squid.logging.get_logger("squid.camera.utils") | ||
|
|
||
|
|
||
| def get_camera(config: CameraConfig, simulated: bool = False) -> AbstractCamera: |
There was a problem hiding this comment.
These are not actually AbstractCamera, but in an effort to make this not a totally insane single PR I'm breaking it up into a few.
ianohara
commented
Feb 18, 2025
| # some cameras had in the pre-AbstractCamera days. | ||
| self._missing_methods = {} | ||
|
|
||
| class MissingAttribImpl: |
There was a problem hiding this comment.
This can be removed once the migration to AbstractCamera is done, but is useful for finding missed migrations.
ianohara
force-pushed
the
ian/camera-interface
branch
2 times, most recently
from
5ddf111 to
309e85a
Compare
ianohara
force-pushed
the
ian/camera-interface
branch
from
309e85a to
e6ffbaf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the AbstractCamera and simulated camera, but without touching existing machinery. A follow up PR will integrate this into the system.
Tested by: unit test on simulated camera creation and basic functionality.