cameras: start plumbing AbstractCamera throughout #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ianohara
force-pushed
the
ian/camera-impl
branch
from
7f909d1 to
76203a0
Compare
ianohara
commented
Feb 18, 2025
| # @@@ will cropping before emitting the signal lead to speedup? | ||
| self.packet_image_for_tracking.emit(image_cropped, camera.frame_ID, camera.timestamp) | ||
| self.timestamp_last_track = time_now | ||
| def on_new_frame(self, frame: squid.abc.CameraFrame): |
There was a problem hiding this comment.
I need to change the frame callback to send out CameraFrame
ianohara
force-pushed
the
ian/camera-impl
branch
2 times, most recently
from
fd860b8 to
cfbc3e5
Compare
ianohara
force-pushed
the
ian/camera-interface
branch
from
577cc0a to
8683f24
Compare
ianohara
force-pushed
the
ian/camera-impl
branch
3 times, most recently
from
6f8710d to
e1c748d
Compare
ianohara
force-pushed
the
ian/camera-interface
branch
from
5ddf111 to
309e85a
Compare
ianohara
force-pushed
the
ian/camera-interface
branch
from
309e85a to
e6ffbaf
Compare
ianohara
force-pushed
the
ian/camera-impl
branch
from
e1c748d to
b741ad9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This starts working through the code and changing all the camera uses to be conformant to the
AbstractCamerainterface. As a result, it depends on #61 .After this is finished, one more PR will need to happen that changes the
Cameraimplementations to beAbstractCameraconformant. I'm doing this one first so we can get everything running with the simulated cam, then pick off the camera implementations 1 by 1.Major Remaining Items:
Tested By: Unit tests still pass, but a lot more testing is needed.