Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:trash internal #803

Merged
merged 2 commits into from
Nov 30, 2023
Merged

:trash internal #803

merged 2 commits into from
Nov 30, 2023

Conversation

Canop
Copy link
Owner

@Canop Canop commented Nov 29, 2023

Add the :trash internal, which instead of deleting a file moves it to the system trash.

You may remap rm to it with

{
    invocation: "rm"
    internal: "trash {file}"
    leave_broot: false
}

Fix #799

@Canop Canop merged commit ae8a6bd into main Nov 30, 2023
1 check passed
@Canop Canop deleted the trash branch November 30, 2023 09:06
@FrancescElies
Copy link
Contributor

Late report is better than no report, windows nushell 0.87.1, works fine, internal trash command moves file to trash.

@Canop
Copy link
Owner Author

Canop commented Dec 4, 2023

Late report is better than no report

100%. Thanks

dead10ck added a commit to dead10ck/broot that referenced this pull request May 7, 2024
Since Canop#803 introduced a dependency on the trash crate, broot does not
compile any more on Android. This change makes the trash crate only
pulled in on platforms which support it, and otherwise the trash command
displays an error.
@dead10ck dead10ck mentioned this pull request May 7, 2024
dead10ck added a commit to dead10ck/broot that referenced this pull request May 7, 2024
Since Canop#803 introduced a dependency on the trash crate, broot does not
compile any more on Android. This change makes the trash crate only
pulled in on platforms which support it, and otherwise the trash command
displays an error.
dead10ck added a commit to dead10ck/broot that referenced this pull request May 7, 2024
Since Canop#803 introduced a dependency on the trash crate, broot does not
compile any more on Android. This change makes the trash crate only
pulled in on platforms which support it, and otherwise the trash command
displays an error.
dead10ck added a commit to dead10ck/broot that referenced this pull request May 7, 2024
Since Canop#803 introduced a dependency on the trash crate, broot does not
compile any more on Android. This change makes the trash crate only
pulled in on platforms which support it, and otherwise the trash command
displays an error.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Optionally use system trash implementation when using rm
2 participants