Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does not compile on Termux (Android) any more #861

Closed
dead10ck opened this issue Mar 27, 2024 · 2 comments · Fixed by #877
Closed

Does not compile on Termux (Android) any more #861

dead10ck opened this issue Mar 27, 2024 · 2 comments · Fixed by #877
Labels
bug Something isn't working

Comments

@dead10ck
Copy link
Contributor

Since #803 introduced a dependency on the trash crate, broot does not compile any more, presumably because Android does not have a trash.

error[E0433]: failed to resolve: use of undeclared crate or module `platform`
  --> /data/data/com.termux/files/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/trash-3.3.1/src/lib.rs:67:35
   |
67 |         Self { platform_specific: platform::PlatformTrashContext::new() }
   |                                   ^^^^^^^^ use of undeclared crate or module `platform`

error[E0433]: failed to resolve: use of undeclared crate or module `platform`
  --> /data/data/com.termux/files/home/.cargo/registry/src/index.crates.io-6f17d22bba15001f/trash-3.3.1/src/lib.rs:63:24
   |
63 |     platform_specific: platform::PlatformTrashContext,
   |                        ^^^^^^^^ use of undeclared crate or module `platform`

For more information about this error, try `rustc --explain E0433`.
error: could not compile `trash` (lib) due to 2 previous errors

Ideally trash support would be behind a feature so that there is a way to opt out of this feature on platforms which do not have a trash. The feature could be on by default since most major platforms do, but at least it would be easy to make builds on platforms that do not.

@dead10ck dead10ck added the bug Something isn't working label Mar 27, 2024
@Canop
Copy link
Owner

Canop commented Mar 27, 2024

Ideally trash support would be behind a feature so that there is a way to opt out of this feature on platforms which do not have a trash. The feature could be on by default since most major platforms do, but at least it would be easy to make builds on platforms that do not.

This looks good. Do you prefer to make a PR or that I do it ?

@dead10ck
Copy link
Contributor Author

Cool, thanks for your support. I can make a PR when I get some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants