Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mereg dev into main #10

Merged
merged 3 commits into from
Mar 3, 2024
Merged

mereg dev into main #10

merged 3 commits into from
Mar 3, 2024

Commits on Mar 2, 2024

  1. Merge pull request #9 from COMBINE-lab/main

    Merge pull request #8 from COMBINE-lab/dev
    rob-p authored Mar 2, 2024
    Configuration menu
    Copy the full SHA
    4e559ee View commit details
    Browse the repository at this point in the history

Commits on Mar 3, 2024

  1. Minor iter fix, better meta_info, simplify

    * Fix off-by-one error in len() method of InMemoryAlignmentStore this was
    previously returning 1 too many elements. Practically, this is unlikely
    to result in any difference, but the implementation now should return
    the proper lenght. Also, `ExactSizeIterator` has been implemented in
    the idiomatic way (providing and exact `size_hint()` in the `Iterator`
    implementation and just declaring the iterator as an
    `ExactSizeIterator`).
    
    * Output more information in the `meta_info.json` file produced by
    `oarfish`.
    
    * Simplify the implementation of the SampleWithReplacementIterator;
    removing the old iterator and replacing it with a new, simpler iterator
    with direct access to the `InMemoryAlignmentStore`.
    Rob Patro committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    b1e4f73 View commit details
    Browse the repository at this point in the history
  2. fix: bump deps

    Rob Patro committed Mar 3, 2024
    Configuration menu
    Copy the full SHA
    96883b2 View commit details
    Browse the repository at this point in the history