mereg dev into main #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #8 from COMBINE-lab/dev
* Fix off-by-one error in len() method of InMemoryAlignmentStore this was previously returning 1 too many elements. Practically, this is unlikely to result in any difference, but the implementation now should return the proper lenght. Also, `ExactSizeIterator` has been implemented in the idiomatic way (providing and exact `size_hint()` in the `Iterator` implementation and just declaring the iterator as an `ExactSizeIterator`). * Output more information in the `meta_info.json` file produced by `oarfish`. * Simplify the implementation of the SampleWithReplacementIterator; removing the old iterator and replacing it with a new, simpler iterator with direct access to the `InMemoryAlignmentStore`.
rob-p
added a commit
that referenced
this pull request
Mar 3, 2024
Merge pull request #10 from COMBINE-lab/dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.