GPU Gen Reorganize #1637
Merged
GPU Gen Reorganize #1637
+1,162
−915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremylt
force-pushed
the
jeremy/gen-reorganize
branch
5 times, most recently
from
8b8d0f1
to
5cea011
Compare
jeremylt
force-pushed
the
jeremy/gen-reorganize
branch
from
cca3065
to
d4c0532
Compare
|
It'd probably be nice to migrate these changes to SYCL, but given lack of easy testing access that could be a separate PR. |
|
Yeah, these changes are really easy to get wrong so I'd want to add them to SYCL separately |
jeremylt
force-pushed
the
jeremy/gen-reorganize
branch
2 times, most recently
from
d52d3f8
to
744a73c
Compare
jeremylt
force-pushed
the
jeremy/gen-reorganize
branch
from
744a73c
to
dddbd88
Compare
jrwrigh
approved these changes
Aug 21, 2024
|
If you want to take a swing at the SYCL backend, I'll be happy to test it for you. Should really look into setting up the ALCF CI. |
|
My plan is to do SYCL in a follow-up since that will require more work |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to reorganize GPU Gen JiT string creation so we can more easily enable non-tensor and AtPoints.
This isn't the final form that will enable non-tensor and AtPoints, but this reorganization gives me a good starting point to move forward from.
Plan is squash+merge.