Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip duplicate transpose restrictions #1645

Merged
merged 3 commits into from
Aug 21, 2024
Merged

Conversation

jeremylt
Copy link
Member

Follows #1644
Second half of #1643

This trims out the extra memory footprint and operations when two output fields share the same restriction and target vector.

Copy link
Collaborator

@jrwrigh jrwrigh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

I know the gen backends are a whole different beast, but should these changes be extrapolated to those as well?

backends/blocked/ceed-blocked-operator.c Show resolved Hide resolved
backends/blocked/ceed-blocked-operator.c Show resolved Hide resolved
backends/cuda-ref/ceed-cuda-ref.h Show resolved Hide resolved
backends/ref/ceed-ref-operator.c Show resolved Hide resolved
@jeremylt jeremylt merged commit f8a0df5 into main Aug 21, 2024
27 of 28 checks passed
@jeremylt jeremylt deleted the jeremy/op-rstr-transpose branch August 21, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants