-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding dependabot PR number to dependabot issue title for title uniqueness and automated closeability #8473
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this locally as well using this PR #6919 -- works as you described
When merged in, we would have to manually close the currently open dependabot PRs or update the titles for this to work right? 🤔
Good call, yea this solution only applies to dependabot PRs created after this gets merged, so for any currently open dependabot PRs that never get merged but get superseded by another dependabot PR we'd have to manually close their associated issues or update the titles like you suggested. I think updating the titles is a good idea so we don't have to keep tabs on what gets superseded. I'll add that scenario/process to the cleanup spike! |
Edit: I just realized Github's definition of "closed" is also when a PR gets merged and not just when it's closed closed without merging. So, the scenario would apply to dependabot PRs that get merged after this PR gets merged as well. In light of that, I'll just manually modify issue titles once this is merged in since the issue renaming will need a quickish turnaround. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it with #7555 and everything looks good!
BACKEND PULL REQUEST
Related Issue
Changes Proposed
Testing