Snyk July Review #7895
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,6 +22,8 @@ | |
| "@types/testing-library__jest-dom": "^5.14.5", | ||
| "@uswds/uswds": "^3.8.0", | ||
| "apollo-upload-client": "^17.0.0", | ||
| "axios": "^1.7.2", | ||
|
There was a problem hiding this comment. same question here - what's axios for? There was a problem hiding this comment. See reference below that explains vulnerability: There was a problem hiding this comment. Not sure if this is what you were asking @mehansen but did a |
||
| "babel-jest": "^29.7.0", | ||
|
There was a problem hiding this comment. nit: can we move this under the There was a problem hiding this comment. Change made |
||
| "browserslist": "4.21.10", | ||
| "classnames": "^2.2.6", | ||
| "flagged": "^2.0.10", | ||
|
|
@@ -254,6 +256,7 @@ | |
| ".stories.tsx", | ||
| "<rootDir>/src/app/testQueue/constants.ts", | ||
| "<rootDir>/src/patientApp/timeOfTest/constants.ts" | ||
| ], | ||
| "transformIgnorePatterns": ["node_modules/(?!axios)/"] | ||
|
There was a problem hiding this comment. Do we need this? 🤔 I ran jest without this and it looked to work for me and I don't think we are importing axios anywhere There was a problem hiding this comment. This was for the updated version of smartystreets-javascript-sdk, its no longer needed since we aren't updating that package in this PR. I removed it |
||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6107,9 +6107,9 @@ | |
| "@types/node" "*" | ||
|
|
||
| "@types/smartystreets-javascript-sdk@^1.6.4": | ||
| version "1.6.10" | ||
| resolved "https://registry.yarnpkg.com/@types/smartystreets-javascript-sdk/-/smartystreets-javascript-sdk-1.6.10.tgz#d22d037d582091c28caf549424ee582636311773" | ||
| integrity sha512-WFbVCaojrbtyD81Pr7jM+R5lPQOhr2SjnF1jIDBw+FiRnYelYE3TXuRXF51KA7eOwnLT+kZsQ/ywdQHLp0ZcPA== | ||
| dependencies: | ||
| "@types/express" "*" | ||
|
|
||
|
|
@@ -7418,6 +7418,15 @@ axios@^0.26.1: | |
| dependencies: | ||
| follow-redirects "^1.14.8" | ||
|
|
||
| axios@^1.7.2: | ||
| version "1.7.2" | ||
| resolved "https://registry.yarnpkg.com/axios/-/axios-1.7.2.tgz#b625db8a7051fbea61c35a3cbb3a1daa7b9c7621" | ||
| integrity sha512-2A8QhOMrbomlDuiLeK9XibIBzuHeRcqqNOHp0Cyp5EoJ1IFDh+XZH3A6BkXtv0K4gFGCI0Y4BM7B1wOEi0Rmgw== | ||
| dependencies: | ||
| follow-redirects "^1.15.6" | ||
| form-data "^4.0.0" | ||
| proxy-from-env "^1.1.0" | ||
|
|
||
| axobject-query@^2.2.0: | ||
| version "2.2.0" | ||
| resolved "https://registry.yarnpkg.com/axobject-query/-/axobject-query-2.2.0.tgz#943d47e10c0b704aa42275e20edf3722648989be" | ||
|
|
@@ -10470,7 +10479,7 @@ focus-trap@^7.5.4: | |
| dependencies: | ||
| tabbable "^6.2.0" | ||
|
|
||
| follow-redirects@^1.0.0, follow-redirects@^1.14.8, follow-redirects@^1.15.6: | ||
| version "1.15.6" | ||
| resolved "https://registry.yarnpkg.com/follow-redirects/-/follow-redirects-1.15.6.tgz#7f815c0cda4249c74ff09e95ef97c23b5fd0399b" | ||
| integrity sha512-wWN62YITEaOpSK584EZXJafH1AGpO8RVgElfkuXbTOrPX4fIfOyEpW/CsiNd8JdYrAoOvafRTOEnvsO++qCqFA== | ||
|
|
@@ -10527,7 +10536,7 @@ fork-ts-checker-webpack-plugin@^8.0.0: | |
| semver "^7.3.5" | ||
| tapable "^2.2.1" | ||
|
|
||
| [email protected], form-data@^4.0.0: | ||
| version "4.0.0" | ||
| resolved "https://registry.yarnpkg.com/form-data/-/form-data-4.0.0.tgz#93919daeaf361ee529584b9b31664dc12c9fa452" | ||
| integrity sha512-ETEklSGi5t0QMZuiXoA/Q6vcnxcLQP5vdugSpuAyi6SVGi2clPPp+xgEhuMaHC+zGgn31Kd235W35f7Hykkaww== | ||
|
|
@@ -15305,6 +15314,11 @@ proxy-addr@~2.0.7: | |
| forwarded "0.2.0" | ||
| ipaddr.js "1.9.1" | ||
|
|
||
| proxy-from-env@^1.1.0: | ||
| version "1.1.0" | ||
| resolved "https://registry.yarnpkg.com/proxy-from-env/-/proxy-from-env-1.1.0.tgz#e102f16ca355424865755d2c9e8ea4f24d58c3e2" | ||
| integrity sha512-D+zkORCbA9f1tdWRK0RaCR3GPv50cMxcrz4X8k5LTSUD1Dkw47mKJEZQNunItRTkWwgtaUSo1RVFRIG9ZXiFYg== | ||
|
|
||
| psl@^1.1.33: | ||
| version "1.9.0" | ||
| resolved "https://registry.yarnpkg.com/psl/-/psl-1.9.0.tgz#d0df2a137f00794565fcaf3b2c00cd09f8d5a5a7" | ||
|
|
@@ -16636,9 +16650,9 @@ slice-ansi@^4.0.0: | |
| is-fullwidth-code-point "^3.0.0" | ||
|
|
||
| smartystreets-javascript-sdk@^3.2.0: | ||
| version "3.3.0" | ||
| resolved "https://registry.yarnpkg.com/smartystreets-javascript-sdk/-/smartystreets-javascript-sdk-3.3.0.tgz#759d2e2af5dc785cbe683185826c597f02d24fce" | ||
| integrity sha512-GnQsELshuVTmDIsnptU+1ubluXHcvxICIIOO2jFHso06PQvB6Ql9iQnJxptpx46kyCSH/zoeCcUsKeHjrdj0ZA== | ||
| dependencies: | ||
| axios "^0.26.1" | ||
| axios-retry "3.2.0" | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't done a Snyk PR before so just to make sure I understand: are we pinning these dependencies to specific versions because others have vulnerabilities? or do these just need to be upgraded?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Based on the Snyk scans the previous version of these packages introduced vulnerabilities, so we are upgrading them to to fix the vulnerability. See references below that explain each vulnerability:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Moving forward I'll add the reference to the vulnerability in the description to provide more context