Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TF DB changes #6632

Closed
wants to merge 20 commits into from
Closed

TF DB changes #6632

wants to merge 20 commits into from

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Sep 25, 2023

This will be pushed out at the beginning of 2024

DEVOPS PULL REQUEST

Cases not yet handled

  • DB pw has been updated, but API doesn't report healthy. Slots would not swap, but the db pw would have already been updated. Solution: Write an action to revert pw updates to db before exiting the deployment.

Related Issue

  • Why is this being done? Link to issue, or a few sentences describing why this PR exists

Changes Proposed

  • Downtime measured during testing was between 1m32s and 3m6s. It should stick to the lower end because the database password update process wasn't as optimized during the test where it took 3m6s.

Additional Information

  • decisions that were made
  • notice of future work that needs to be done

Testing

  • How should reviewers verify this PR?

Checklist for Primary Reviewer

Infrastructure

  • Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
  • Any dependencies introduced have been vetted and discussed

Cloud

  • Oncall has been notified if this change is going in after-hours
  • If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

  • Any changes to the startup configuration have been documented in the README

@alismx alismx force-pushed the alis/3673 branch 7 times, most recently from 0967b79 to 6d1836a Compare September 27, 2023 17:56
@CDCgov CDCgov deleted a comment from github-actions bot Sep 27, 2023
@alismx alismx force-pushed the alis/3673 branch 20 times, most recently from 40bc535 to 03af127 Compare October 2, 2023 17:24
@alismx alismx temporarily deployed to dev October 2, 2023 19:18 — with GitHub Actions Inactive
@alismx alismx temporarily deployed to dev October 2, 2023 19:26 — with GitHub Actions Inactive
@alismx alismx force-pushed the alis/3673 branch 3 times, most recently from 549de8b to 9782462 Compare March 14, 2024 18:38
@alismx alismx force-pushed the alis/3673 branch 4 times, most recently from 0aa30aa to 69bd954 Compare March 19, 2024 18:29
Copy link

sonarcloud bot commented Mar 19, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@alismx
Copy link
Collaborator Author

alismx commented Mar 28, 2024

Closing this for now

@alismx alismx closed this Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant