Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump com.smartystreets.api:smartystreets-java-sdk from 3.13.15 to 3.14.0 in /backend + gradle helper update #6397

Merged
merged 3 commits into from
Aug 23, 2023
Merged

Bump com.smartystreets.api:smartystreets-java-sdk from 3.13.15 to 3.14.0 in /backend + gradle helper update #6397

merged 3 commits into from
Aug 23, 2023

Conversation

alismx
Copy link
Collaborator

@alismx alismx commented Aug 22, 2023 •
edited
Loading

BACKEND/DEVOPS PULL REQUEST

Related Issue

Changes Proposed

  • Bump com.smartystreets.api:smartystreets-java-sdk
  • Updates the gradle Dependabot helper

Testing

  • The GH action changes need to be on the main branch so Dependabot uses it when it opens PRs for the backend. I'll keep an eye on next week's PRs to double check this is working as intended. I manually ran it this time; that's viewable here
  • Backend changes will need to be tested by a dev.

Checklist for Primary Reviewer

  • Any large-scale changes have been deployed to test, dev, or pentest and smoke tested
  • Any content updates (user-facing error messages, etc) have been approved by content team
  • Any changes that might generate questions in the support inbox have been flagged to the support team
  • GraphQL schema changes are backward compatible with older version of the front-end
  • Changes comply with the SimpleReport Style Guide
  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
  • Any dependencies introduced have been vetted and discussed
  • Any changes to the startup configuration have been documented in the README

Infrastructure

  • Consult the results of the terraform-plan job inside the "Terraform Checks" workflow run for this PR. Confirm that there are no unexpected changes!

Security

  • Changes with security implications have been approved by a security engineer (changes to authentication, encryption, handling of PII, etc.)
  • Any dependencies introduced have been vetted and discussed

Cloud

  • Oncall has been notified if this change is going in after-hours
  • If there are changes that cannot be tested locally, this has been deployed to our Azure test, dev, or pentest environment for verification

Documentation

  • Any changes to the startup configuration have been documented in the README

@alismx alismx force-pushed the alis/dependabot_gradle_locks_update branch from 408f981 to 399cf18 Compare August 22, 2023 19:03
@alismx alismx mentioned this pull request Aug 22, 2023
Closed
@alismx alismx force-pushed the alis/dependabot_gradle_locks_update branch 3 times, most recently from a6a8e05 to 2416261 Compare August 22, 2023 19:27
@alismx alismx marked this pull request as ready for review August 22, 2023 19:46
@alismx alismx changed the title Alis/dependabot gradle locks update Bump com.smartystreets.api:smartystreets-java-sdk from 3.13.15 to 3.14.0 in /backend + gradle helper update Aug 22, 2023
@alismx alismx enabled auto-merge August 22, 2023 19:55
@alismx alismx requested review from BobanL, rin-skylight, a team, DanielSass, zdeveloper, mehansen, nathancrtr, fzhao99 and johanna-skylight and removed request for a team August 22, 2023 19:55
@alismx alismx force-pushed the alis/dependabot_gradle_locks_update branch from da44a0f to 0f663be Compare August 22, 2023 19:59
@alismx alismx marked this pull request as draft August 22, 2023 20:55
auto-merge was automatically disabled August 22, 2023 20:55

Pull request was converted to draft

@alismx alismx force-pushed the alis/dependabot_gradle_locks_update branch 8 times, most recently from 16e22eb to e9c5463 Compare August 22, 2023 21:43
@alismx alismx force-pushed the alis/dependabot_gradle_locks_update branch 6 times, most recently from 59d0ef8 to 98a8908 Compare August 22, 2023 22:32
@alismx alismx force-pushed the alis/dependabot_gradle_locks_update branch from 46b3b07 to 2c913ee Compare August 22, 2023 22:39
@alismx alismx marked this pull request as ready for review August 22, 2023 22:42
@alismx alismx enabled auto-merge August 22, 2023 22:42
@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

BobanL
BobanL approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@BobanL BobanL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking forward to seeing this in action next Sunday

@alismx alismx added this pull request to the merge queue Aug 23, 2023
zdeveloper
zdeveloper approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@zdeveloper zdeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for fixing the gradle locks updates

Merged via the queue into main with commit d4404d8 Aug 23, 2023
33 checks passed
@alismx alismx deleted the alis/dependabot_gradle_locks_update branch August 23, 2023 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BobanL BobanL BobanL approved these changes

@zdeveloper zdeveloper zdeveloper approved these changes

@rin-skylight rin-skylight Awaiting requested review from rin-skylight

@DanielSass DanielSass Awaiting requested review from DanielSass DanielSass was automatically assigned from CDCgov/simplereport-engineeringreviews

@mehansen mehansen Awaiting requested review from mehansen

@nathancrtr nathancrtr Awaiting requested review from nathancrtr

@fzhao99 fzhao99 Awaiting requested review from fzhao99

@johanna-skylight johanna-skylight Awaiting requested review from johanna-skylight

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@alismx @zdeveloper @BobanL