Un-skip E2E test: idletimeout.spec.ts if needed #16402
Conversation
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Manifest Files |
| // Add/Sub 500 ms to account for variance | ||
| const timeoutLow = timeout - 500; | ||
| const timeoutHigh = timeout + 500; | ||
| const timeout = parseInt(process.env.VITE_IDLE_TIMEOUT ?? "900000"); |
There was a problem hiding this comment.
nit: can we make the "900000" an integer?
There was a problem hiding this comment.
Negative, the function expects a string so I'm making sure to provide a string fallback for the env var
| @@ -37,27 +36,28 @@ const test = baseTest.extend<OrganizationPageFixtures>({ | |||
| frontendWarningsLogPath, | |||
| isFrontendWarningsLog, | |||
| }); | |||
| await page.page.clock.install(); | |||
There was a problem hiding this comment.
Not sure how time is persisted in these tests, but is it worth cleaning up afterwards like so:
test.afterEach(async ({ page }) => {
await page.clock.uninstall();
});
There was a problem hiding this comment.
There is no uninstall method for the fake clock
…outspects-if-needed
|
Branch deployed to Chromatic 🚀.
View via: |
|
|
jpandersen87
deleted the
experience/16060-Un-skip-E2E-test-idletimeoutspects-if-needed
branch
Fixes #16060
This PR unskips the idletimeout test and adds a new one in order to test time moving forward under/over the timeout. The tests use the page.clock functions in order to artificially move time forward mimicing idle.