Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

15805 version in azure events #15902

Merged
merged 5 commits into from
Sep 24, 2024
Merged

15805 version in azure events #15902

merged 5 commits into from
Sep 24, 2024

Conversation

jack-h-wang
Copy link
Collaborator

@jack-h-wang jack-h-wang commented Sep 17, 2024 •
edited
Loading

This PR makes the current commit hash available to the main project and adds it to Azure events.

Test Steps:

  1. Run Gradle task package or quickPackage and ensure the project builds successfully.

Changes

  • Add Gradle task to generate a Version object usable in the main project.
  • Add version to ReportEventData and supply the commit hash from the Version object.

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • Added tests?

Linked Issues

To be done

@jack-h-wang jack-h-wang added the platform Platform Team label Sep 17, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Test Results

1 232 tests  ±0   1 228 ✅ ±0   7m 26s ⏱️ -1s
  162 suites ±0       4 💤 ±0 
  162 files   ±0       0 ❌ ±0 

Results for commit db7a7f9. ± Comparison against base commit e5cd452.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 17, 2024 •
edited
Loading

Integration Test Results

 53 files  ±0   53 suites  ±0   27m 36s ⏱️ +10s
410 tests ±0  401 ✅ ±0  9 💤 ±0  0 ❌ ±0 
413 runs  ±0  404 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit db7a7f9. ± Comparison against base commit e5cd452.

♻️ This comment has been updated with latest results.

@jack-h-wang jack-h-wang force-pushed the platform/jwang/15805-version-in-azure-events branch from d3579b8 to f5b4e11 Compare September 19, 2024 18:58
@jack-h-wang jack-h-wang marked this pull request as ready for review September 19, 2024 18:59
@jack-h-wang jack-h-wang requested a review from a team as a code owner September 19, 2024 18:59
@jack-h-wang jack-h-wang force-pushed the platform/jwang/15805-version-in-azure-events branch from f5b4e11 to bd85a2e Compare September 20, 2024 00:48
@thetaurean thetaurean self-assigned this Sep 20, 2024
@jack-h-wang jack-h-wang force-pushed the platform/jwang/15805-version-in-azure-events branch from bd85a2e to 4b5c8ac Compare September 21, 2024 14:18
thetaurean
thetaurean reviewed Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@thetaurean thetaurean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple minor questions / suggestions.

prime-router/build.gradle.kts Show resolved Hide resolved
prime-router/build.gradle.kts Show resolved Hide resolved
prime-router/src/test/kotlin/azure/ActionHistoryTests.kt Show resolved Hide resolved
thetaurean
thetaurean approved these changes Sep 23, 2024
View reviewed changes
Copy link
Collaborator

@thetaurean thetaurean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jack-h-wang jack-h-wang force-pushed the platform/jwang/15805-version-in-azure-events branch from 4b5c8ac to a46416e Compare September 24, 2024 14:11
arnejduranovic
arnejduranovic reviewed Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@arnejduranovic arnejduranovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once deployed, let's verify that the commit in the events matches the commit in the json file by logging in to SSH (process described in deployment doc)

prime-router/build.gradle.kts Show resolved Hide resolved
@jack-h-wang jack-h-wang force-pushed the platform/jwang/15805-version-in-azure-events branch from a46416e to ba44fa6 Compare September 24, 2024 16:58
@jack-h-wang jack-h-wang force-pushed the platform/jwang/15805-version-in-azure-events branch from 32c2a8b to db7a7f9 Compare September 24, 2024 17:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 24, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@jack-h-wang jack-h-wang merged commit ee8eb29 into master Sep 24, 2024
22 checks passed
@jack-h-wang jack-h-wang deleted the platform/jwang/15805-version-in-azure-events branch September 24, 2024 18:24
@jack-h-wang jack-h-wang mentioned this pull request Sep 24, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arnejduranovic arnejduranovic arnejduranovic approved these changes

@thetaurean thetaurean thetaurean approved these changes

Assignees

@thetaurean thetaurean

Labels
platform Platform Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jack-h-wang @thetaurean @arnejduranovic