Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable OWASP Dependency Check plugin #15335

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

snesm
Copy link
Contributor

@snesm snesm commented Jul 25, 2024

This PR enables the OWASP Dependency Check plugin. This plugin is easier to use than the OWASP Dependency Check CLI.

If you are suggesting a fix for a currently exploitable issue, please disclose the issue to the prime-reportstream team directly outside of GitHub instead of filing a PR, so we may immediately patch the affected systems before a disclosure. See SECURITY.md/Reporting a Vulnerability for more information.

Test Steps:

  1. ../gradlew dependencyCheckAnalyze

Changes

Checklist

Testing

  • Tested locally?
  • Ran ./prime test or ./gradlew testSmoke against local Docker ReportStream container?
  • (For Changes to /frontend-react/...) Ran npm run lint:write?
  • Added tests?

Process

  • Are there licensing issues with any new dependencies introduced?
  • Includes a summary of what a code reviewer should test/verify?
  • Updated the release notes?
  • Database changes are submitted as a separate PR?
  • DevOps team has been notified if PR requires ops support?

Linked Issues

  • Fixes #issue

To Be Done

Create GitHub issues to track the work remaining, if any

  • #issue

Specific Security-related subjects a reviewer should pay specific attention to

  • Does this PR introduce new endpoints?
    • new endpoint A
    • new endpoint B
  • Does this PR include changes in authentication and/or authorization of existing endpoints?
  • Does this change introduce new dependencies that need vetting?
  • Does this change require changes to our infrastructure?
  • Does logging contain sensitive data?
  • Does this PR include or remove any sensitive information itself?

If you answered 'yes' to any of the questions above, conduct a detailed Review that addresses at least:

  • What are the potential security threats and mitigations? Please list the STRIDE threats and how they are mitigated
    • Spoofing (faking authenticity)
      • Threat T, which could be achieved by A, is mitigated by M
    • Tampering (influence or sabotage the integrity of information, data, or system)
    • Repudiation (the ability to dispute the origin or originator of an action)
    • Information disclosure (data made available to entities who should not have it)
    • Denial of service (make a resource unavailable)
    • Elevation of Privilege (reduce restrictions that apply or gain privileges one should not have)
  • Have you ensured logging does not contain sensitive data?
  • Have you received any additional approvals needed for this change?

@snesm snesm added the security Work Type label to flag work related to security label Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

OpenSSF Scorecard

PackageVersionScoreDetails

Scanned Manifest Files

@snesm snesm changed the title Enable OWASP ependency check plugin Enable OWASP Dependency Check plugin Jul 25, 2024
Copy link

github-actions bot commented Jul 25, 2024

Test Results

1 232 tests  ±0   1 228 ✅ ±0   7m 30s ⏱️ -10s
  162 suites ±0       4 💤 ±0 
  162 files   ±0       0 ❌ ±0 

Results for commit 625bf34. ± Comparison against base commit 351db90.

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Jul 25, 2024

Integration Test Results

 53 files  ±0   53 suites  ±0   27m 33s ⏱️ -29s
410 tests ±0  401 ✅ ±0  9 💤 ±0  0 ❌ ±0 
413 runs  ±0  404 ✅ ±0  9 💤 ±0  0 ❌ ±0 

Results for commit 625bf34. ± Comparison against base commit 351db90.

♻️ This comment has been updated with latest results.

@snesm snesm marked this pull request as ready for review July 25, 2024 15:44
@snesm snesm requested a review from a team as a code owner July 25, 2024 15:44
@snesm snesm added dependencies Pull requests that update a dependency file java Pull requests that update Java code labels Jul 25, 2024
Copy link

sonarcloud bot commented Aug 20, 2024

Copy link

sonarcloud bot commented Sep 27, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file java Pull requests that update Java code security Work Type label to flag work related to security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant