fix: encounter date sorting

[mcmcgrath13]

PULL REQUEST

Summary

Fix encounter date sorting:

1. SQL server had validation code that wasn't accounting for the difference in UI column and DB column names. This was causing report_date sorting to fall back to create date sorting
2. The initialization of the EcrTableClient was overwriting the search params/props provided value
3. Move the useQueryParam hook to its own file in a new hooks folder so it's more easily reused across different components (felt weird importing from BaseFilter here)
4. Generally simplify the EcrTableClient logic

Related Issue

Fixes #3134

Acceptance Criteria

Dates should be properly ordered

Additional Information

[codecov]

Codecov Report

Attention: Patch coverage is 91.30435% with 4 lines in your changes missing coverage. Please review.

Project coverage is 89.28%. Comparing base (33cf61e) to head (8335173).
Report is 832 commits behind head on main.

Files with missing lines	Patch %	Lines
...s/ecr-viewer/src/app/components/EcrTableClient.tsx	69.23%	4 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #3177      +/-   ##
==========================================
+ Coverage   87.07%   89.28%   +2.21%     
==========================================
  Files         221       85     -136     
  Lines       13723     4267    -9456     
  Branches      726      729       +3     
==========================================
- Hits        11949     3810    -8139     
+ Misses       1765      436    -1329     
- Partials        9       21      +12     

Flag	Coverage Δ
ecr-viewer	91.10% <91.30%> (-0.01%)	⬇️
fhir-converter	?
ingestion	?
message-parser	?
message-refiner	?
orchestration	85.67% <ø> (ø)
record-linkage	?
trigger-code-reference	?
validation	?

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines	Coverage Δ
...iners/ecr-viewer/src/app/components/BaseFilter.tsx	100.00% <100.00%> (ø)
...ntainers/ecr-viewer/src/app/components/Filters.tsx	97.72% <100.00%> (+0.01%)	⬆️
...tainers/ecr-viewer/src/app/hooks/useQueryParam.tsx	100.00% <100.00%> (ø)
containers/ecr-viewer/src/app/page.tsx	100.00% <100.00%> (ø)
.../ecr-viewer/src/app/services/listEcrDataService.ts	74.58% <100.00%> (+0.40%)	⬆️
...s/ecr-viewer/src/app/components/EcrTableClient.tsx	86.53% <69.23%> (-2.80%)	⬇️

... and 137 files with indirect coverage changes

[BobanL]

Locally I'm consistently getting the first two tests fail on chrome. I think it has to do with the compiling of the /view-data endpoint that takes ~10-15 seconds. Previously it would work because page.waitForUrl has a longer timeout.
If we increase the timeout on expect in the playwright config to be 15 seconds (expect: { timeout: 15_000}) we can match the functionality that waitForUrl was providing.

[mcmcgrath13]

ah, nice! everything was passing locally for me, but everyone hates flaky tests - I'll update

[mcmcgrath13]

just pushed it up, could you try again @BobanL ?