Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure old .env.local file doesn't cause issues when running local dev #3175

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

robertmitchellv
Copy link
Collaborator

PULL REQUEST

Summary

In containers/ecr-viewer/setup-env.sh there is only logic to copy .env.sample if .env.local does not exist. However, if any additional code is checked into .env.sample after you've already run the setup-env.sh or npm run setup-local-env there is no way when running the steps for local deployment to ensure that recent changes are copied to .env.local. We need more ways to check for these kinds of changes to ensure that dev time isn't wasted chasing down error messages that seem like docker issues but are in fact related to .env.local.

Related Issue

Fixes #3174

Acceptance Criteria

  • If changes are made to .env.sample then when performing steps to run the application locally from the README there is an opportunity to update .env.local so that local deployment continues to work

Additional Information

Want to make sure that this script waiting for a response from the user will not break or jeopardize any CI or other deployments of the application.

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (bac3146) to head (907e5f9).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3175      +/-   ##
==========================================
+ Coverage   87.07%   91.10%   +4.03%     
==========================================
  Files         221       59     -162     
  Lines       13723     2868   -10855     
  Branches      739      726      -13     
==========================================
- Hits        11949     2613    -9336     
+ Misses       1753      246    -1507     
+ Partials       21        9      -12     
Flag Coverage Δ
ecr-viewer 91.10% <ø> (ø)
fhir-converter ?
ingestion ?
message-parser ?
message-refiner ?
orchestration ?
record-linkage ?
trigger-code-reference ?
validation ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 167 files with indirect coverage changes

@robertmitchellv robertmitchellv added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit 33cf61e Jan 22, 2025
16 checks passed
@robertmitchellv robertmitchellv deleted the robert/3174-env-shell-updates branch January 22, 2025 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make sure old .env.local files do not cause issues when running local dev
2 participants