Make sure old .env.local
file doesn't cause issues when running local dev
#3175
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
In
containers/ecr-viewer/setup-env.sh
there is only logic to copy.env.sample
if.env.local
does not exist. However, if any additional code is checked into.env.sample
after you've already run thesetup-env.sh
ornpm run setup-local-env
there is no way when running the steps for local deployment to ensure that recent changes are copied to .env.local. We need more ways to check for these kinds of changes to ensure that dev time isn't wasted chasing down error messages that seem like docker issues but are in fact related to.env.local
.Related Issue
Fixes #3174
.env.local
files do not cause issues when running local dev #3174Acceptance Criteria
.env.sample
then when performing steps to run the application locally from the README there is an opportunity to update.env.local
so that local deployment continues to workAdditional Information
Want to make sure that this script waiting for a response from the user will not break or jeopardize any CI or other deployments of the application.
Checklist