Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: setup and add e2e tests using playwright #3067

Merged
merged 150 commits into from
Jan 8, 2025
Merged

test: setup and add e2e tests using playwright #3067

merged 150 commits into from
Jan 8, 2025

Conversation

BobanL
Copy link
Collaborator

@BobanL BobanL commented Dec 16, 2024 •
edited
Loading

PULL REQUEST

Summary

  • Add playwright and create two test files for ecr-viewer and ecr-library
  • Add Job to run playwright tests in github actions
  • Remove makefile

Related Issue

Fixes #2969

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

Additional Information

Anything else the review team should know?

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

BobanL added 30 commits November 25, 2024 16:15
@BobanL
ignore .next in jest
2b06396
@BobanL
mute console error from jest results
33a8246
@BobanL
rename app_env to nbs_auth
b262450 
docker compose --env-file .env.local --profile "*" up to test with different configs
@BobanL
Remove app env check around s3 client
e7878dc
@BobanL
add collection variables for env groups
881700f
@BobanL
fix typos in .env files
2e24379
@BobanL
create single azure-storage image that contains both azurite and azur…
a1b3f0b 
…e cli
@BobanL
add additional chaining to run specific collections
50a94be
@BobanL
fix local-dev command to use collection
d267607
@BobanL
update create-seed-data to use different configs depending on metadata
d11622e
@BobanL
rename schemas
aaf6922
@BobanL
update .env.sample to include collection
2c154e8
@BobanL
remove azure-storage-init from orchestration
0edacc9
@BobanL
update orchestration docker compose to add collection
961555e
@BobanL
add metadata db schema in the env variable
c2c1048
@BobanL
remove undefined values
15bf72e
@BobanL
remove nbs_auth value
c53a3b9
@BobanL
Remove redundant variables
48c65e2
@BobanL
change to aws non integrated and add timeout
952e48c
@BobanL
Merge branch 'main' into boban/2873-env-variable-collections
8e7b765
@BobanL
add docker ignore
4625ccc
@BobanL
Merge branch 'main' into boban/2873-env-variable-collections
ac67fb2
@BobanL
add more to docker ignore
18a92af
@BobanL
Comment all from .env
787b6d7
@BobanL
fix tests that were relying on .env file
b367cfb
@BobanL
make metadata variables optional
81f1de5
@BobanL
pull out saveFhirMetadata into it's own function
1f27bfb
@BobanL
delete .env
aaeb383
@BobanL
Use PersistenceResponse instead of Nextjs response
8d44b5a
@BobanL
console log error messages
d091bf1
JNygaard-Skylight
JNygaard-Skylight requested changes Jan 3, 2025
View reviewed changes
containers/ecr-viewer/package.json Outdated Show resolved Hide resolved
containers/ecr-viewer/playwright.config.ts Outdated Show resolved Hide resolved
JNygaard-Skylight
JNygaard-Skylight requested changes Jan 3, 2025
View reviewed changes
Copy link
Collaborator

@JNygaard-Skylight JNygaard-Skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add some documentation on how to run the Playwright tests in a readme?

mcmcgrath13
mcmcgrath13 reviewed Jan 3, 2025
View reviewed changes
.github/workflows/container-ecr-viewer.yaml

- name: Run seed data conversion
working-directory: ./containers/${{env.CONTAINER}}
run: npm run convert-seed-data
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could we limit this to a smaller number of ecrs to save time?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's a little out of scope for this work now since it would impact the seed script file. We do have some exiting tech debt that would handle this.

JNygaard-Skylight
JNygaard-Skylight approved these changes Jan 6, 2025
View reviewed changes
Copy link
Collaborator

@JNygaard-Skylight JNygaard-Skylight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@BobanL BobanL enabled auto-merge January 8, 2025 13:16
@BobanL BobanL added this pull request to the merge queue Jan 8, 2025
Merged via the queue into main with commit 5c15209 Jan 8, 2025
16 checks passed
@BobanL BobanL deleted the boban/2969-e2e-tests branch January 8, 2025 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcmcgrath13 mcmcgrath13 mcmcgrath13 left review comments

@JNygaard-Skylight JNygaard-Skylight JNygaard-Skylight approved these changes

@akasper akasper Awaiting requested review from akasper akasper is a code owner

@angelathe angelathe Awaiting requested review from angelathe angelathe is a code owner

@austin-hall-skylight austin-hall-skylight Awaiting requested review from austin-hall-skylight austin-hall-skylight is a code owner

@gordonfarrell gordonfarrell Awaiting requested review from gordonfarrell gordonfarrell is a code owner

@lina-roth lina-roth Awaiting requested review from lina-roth lina-roth is a code owner

@robertmitchellv robertmitchellv Awaiting requested review from robertmitchellv robertmitchellv is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Cypress tests with Playwright
4 participants
@BobanL @mcmcgrath13 @JNygaard-Skylight @angelathe