testing: enforce no error or warning logs (#3097)

* test: fix test table * test: squash logs * test: enforce no errors and warnings
CDCgov · Jan 8, 2025 · 3a089b7 · 3a089b7
1 parent 5c15209
commit 3a089b7
Show file tree

Hide file tree

Showing 7 changed files with 64 additions and 34 deletions.
diff --git a/containers/ecr-viewer/jest.setup.ts b/containers/ecr-viewer/jest.setup.ts
@@ -1,12 +1,15 @@
 import "@testing-library/jest-dom";
 import { toHaveNoViolations } from "jest-axe";
+import failOnConsole from "jest-fail-on-console";
 import * as matchers from "jest-extended";
 import { TextEncoder } from "util";
 import router from "next-router-mock";
 import { clearEvaluateCache } from "@/app/view-data/utils/evaluate";
 
 global.TextEncoder = TextEncoder;
 
+failOnConsole();
+
 expect.extend(toHaveNoViolations);
 expect.extend(matchers);
 

diff --git a/containers/ecr-viewer/package-lock.json b/containers/ecr-viewer/package-lock.json
diff --git a/containers/ecr-viewer/package.json b/containers/ecr-viewer/package.json
@@ -96,6 +96,7 @@
     "jest-axe": "^8.0.0",
     "jest-environment-jsdom": "^29.7.0",
     "jest-extended": "^4.0.2",
+    "jest-fail-on-console": "^3.3.1",
     "jest-fetch-mock": "^3.0.3",
     "postcss": "^8.4.38",
     "prettier": "3.1.0",

diff --git a/containers/ecr-viewer/src/app/tests/component-utils.test.tsx b/containers/ecr-viewer/src/app/tests/component-utils.test.tsx
@@ -33,9 +33,13 @@ describe("Metrics", () => {
     const basePath = "https://example.com";
     const metricOptions = { key: "value" };
 
+    jest.spyOn(console, "error").mockImplementation();
+
     await expect(metrics(basePath, metricOptions)).rejects.toThrow(
       "Sorry, we couldn't find this endpoint.",
     );
+
+    expect(console.error).toHaveBeenCalledOnce();
   });
 
   it("handles internal server error", async () => {
@@ -47,8 +51,12 @@ describe("Metrics", () => {
     const basePath = "https://example.com";
     const metricOptions = { key: "value" };
 
+    jest.spyOn(console, "error").mockImplementation();
+
     await expect(metrics(basePath, metricOptions)).rejects.toThrow(
       "Internal Server Error",
     );
+
+    expect(console.error).toHaveBeenCalledOnce();
   });
 });
diff --git a/containers/ecr-viewer/src/app/tests/components/EcrTable.test.tsx b/containers/ecr-viewer/src/app/tests/components/EcrTable.test.tsx
@@ -1,5 +1,5 @@
 import { axe } from "jest-axe";
-import { render } from "@testing-library/react";
+import { act, render } from "@testing-library/react";
 import EcrTable from "@/app/components/EcrTable";
 import { EcrDisplay, listEcrData } from "@/app/services/listEcrDataService";
 import router from "next-router-mock";
@@ -66,7 +66,9 @@ describe("EcrTable", () => {
         filterDate: mockDateRange,
       }),
     );
-    expect(await axe(container)).toHaveNoViolations();
+    await act(async () => {
+      expect(await axe(container)).toHaveNoViolations();
+    });
   });
 
   it("should call listEcrDataService with all params", async () => {

diff --git a/containers/ecr-viewer/src/app/tests/components/Encounter.test.tsx b/containers/ecr-viewer/src/app/tests/components/Encounter.test.tsx
@@ -27,16 +27,20 @@ describe("Encounter", () => {
         table: true,
         value: (
           <table>
-            <tr>
-              <th>Name</th>
-              <th>Role</th>
-              <th>Dates</th>
-            </tr>
-            <tr>
-              <td>Test</td>
-              <td>ATND</td>
-              <td>Start: 1/2/2023</td>
-            </tr>
+            <thead>
+              <tr>
+                <th>Name</th>
+                <th>Role</th>
+                <th>Dates</th>
+              </tr>
+            </thead>
+            <tbody>
+              <tr>
+                <td>Test</td>
+                <td>ATND</td>
+                <td>Start: 1/2/2023</td>
+              </tr>
+            </tbody>
           </table>
         ),
       },

diff --git a/containers/ecr-viewer/src/app/tests/components/__snapshots__/Encounter.test.tsx.snap b/containers/ecr-viewer/src/app/tests/components/__snapshots__/Encounter.test.tsx.snap
@@ -68,28 +68,32 @@ exports[`Encounter should match snapshot 1`] = `
                 class="grid-col-auto width-full text-pre-line"
               >
                 <table>
-                  <tr>
-                    <th>
-                      Name
-                    </th>
-                    <th>
-                      Role
-                    </th>
-                    <th>
-                      Dates
-                    </th>
-                  </tr>
-                  <tr>
-                    <td>
-                      Test
-                    </td>
-                    <td>
-                      ATND
-                    </td>
-                    <td>
-                      Start: 1/2/2023
-                    </td>
-                  </tr>
+                  <thead>
+                    <tr>
+                      <th>
+                        Name
+                      </th>
+                      <th>
+                        Role
+                      </th>
+                      <th>
+                        Dates
+                      </th>
+                    </tr>
+                  </thead>
+                  <tbody>
+                    <tr>
+                      <td>
+                        Test
+                      </td>
+                      <td>
+                        ATND
+                      </td>
+                      <td>
+                        Start: 1/2/2023
+                      </td>
+                    </tr>
+                  </tbody>
                 </table>
               </div>
             </div>