Skip to content

Commit

Permalink
chore: replace pretty-format-json with prettier functionality (#3090)
Browse files Browse the repository at this point in the history
* downgrade prettier to 3.1.0 and eslint to 8.56

* remove precommit auto update since we should pin eslint and prettier to earlier versions

* remove pretty-format-json

* run prettier

* exclude example folder

* exclude a lot of files from pre-commit

* [pre-commit.ci] auto fixes from pre-commit hooks

* update base service tests

* Update .pre-commit-config.yaml

* remove unnecssary skip

* [pre-commit.ci] auto fixes from pre-commit hooks

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
  • Loading branch information
BobanL and pre-commit-ci[bot] authored Jan 6, 2025
1 parent 8826d74 commit 2c0029c
Show file tree
Hide file tree
Showing 146 changed files with 1,626 additions and 2,706 deletions.
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/DxT-bug-template.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
name: DxT Bug Template
about: Capture bugs with this
title: ''
title: ""
labels: DxT
assignees: ''

assignees: ""
---

## Description
Expand All @@ -15,7 +14,7 @@ _Provide a high-level summary of the bug and what impact it has_

_List out the steps in detail to reproduce the bug_

1.
1.

## Expected Result

Expand All @@ -30,6 +29,7 @@ _Explain what's happening now when the bug is present. Attach screenshot if appl
_Provide an estimate for level of impact the bug has today by placing an X in the applicable bracket_

#### Priority

- [ ] **Low priority** _The bug does not have to be fixed immediately. High and medium priority bugs should be addressed first._
- [ ] **Medium priority** _Typically, medium-priority bugs do not affect customers directly and therefore can be fixed in the normal course of testing and development._
- [ ] **High priority** _High priority bugs must be addressed immediately. They often affect the app’s functionality and impact customers and their user experience. They must take priority._
Expand Down
21 changes: 12 additions & 9 deletions .github/ISSUE_TEMPLATE/DxT-qa-ticket-template.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
---
name: DxT QA Ticket Template
about: Template for eCR Viewer QA efforts
title: ''
title: ""
labels: DxT, quality-assurance-testing
assignees: ''

assignees: ""
---

## Action Requested

As part of our efforts to QA the eCR Viewer please thoroughly test the following eCR in the eCR viewer: [Link to eCR ##: ID]()

## Acceptance Criteria

- [ ] The eCR has been run through orchestration and the pipeline
- [ ] The eCR has been viewed in the Viewer and compared side by side to the original XML/HTML file
- [ ] The eCR is appearing properly in the non-integrated homepage table
Expand All @@ -19,18 +20,20 @@ As part of our efforts to QA the eCR Viewer please thoroughly test the following
## Basic process for comparing eCR Viewer output and original eCR

Steps to follow:

1. Go through the eCR Viewer fields from top to bottom
2. For every field in the eCR Viewer, do the following:
a. Check that you can find the data somewhere in the original HTML or XML
b. Check the content of the fields to see if they are the same or different
a. Check that you can find the data somewhere in the original HTML or XML
b. Check the content of the fields to see if they are the same or different
3. Then, looking at the original eCR HTML, do a quick scroll through to see if there is any data or sections present that we aren't showing in the eCR Viewer

Things to look out for:
- **Do we have only some of the data that you can see in the HTML or XML? Does it seem like it could be important information to users?**

- **Do we have only some of the data that you can see in the HTML or XML? Does it seem like it could be important information to users?**
- for ex: if the HTML says "Race: White, European" and ours says "Race: White" --> we will want to note that as a problem that we are missing some data that is available!
- **Does the formatting of the data look odd/different?**
- **Does the formatting of the data look odd/different?**
- for ex: did we get rid of page breaks such that narrative text is an overwhelming wall of text?
- **Are all addresses and phone numbers available in the HTML or XML available somewhere in our viewer?**
- **Are all addresses and phone numbers available in the HTML or XML available somewhere in our viewer?**
- we want to make sure we aren't missing any potential contact info for facilities that an end user may need to call for follow up
- **Do you notice anything that seems like a bug with our Viewer?**
- **Do you notice anything that seems like a bug with our Viewer?**
- for ex: is there a field showing up with no data in it? is there an edge case with the eCR data you're looking at that we didn't account for?
13 changes: 5 additions & 8 deletions .github/ISSUE_TEMPLATE/DxT-spike-template.md
Original file line number Diff line number Diff line change
@@ -1,33 +1,30 @@
---
name: DxT Spike Template
about: Used for exploratory engineering spikes
title: ''
title: ""
labels: DxT
assignees: ''

assignees: ""
---

## What needs to be done

_Provide a summary of the task that needs to be completed_


## Why it needs to be done

_Describe the importance or impact of completing this task_


## Timebox

_How much time should be dedicated to this spike?_


## To-do list

_list out actions to be taken for this spike:_
- [ ]

- [ ]

## Additional context

[OPTIONAL, delete if not needed]
[OPTIONAL, delete if not needed]
_Include any additional context or information here that doesn't fit into other parts of the template_
15 changes: 5 additions & 10 deletions .github/ISSUE_TEMPLATE/DxT-task-template.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,32 @@
---
name: DxT Task Template
about: A generic template for any task that can be adapted for multiple uses
title: ''
title: ""
labels: DxT
assignees: ''

assignees: ""
---

## What needs to be done

_Provide a summary of the task that needs to be completed_


## Why it needs to be done

_Describe the importance or impact of completing this task_


## Acceptance Criteria

_List out all expected functionality/requirements_

-

-

## Technical Notes

_Owned by eng team - write out any important technical considerations such as: architecture plan/notes, data dependencies, testing plan, etc. Also link any tickets that are dependent on or related to this task_

-

-

## Additional context

[OPTIONAL, delete if not needed]
[OPTIONAL, delete if not needed]
_Include any additional context or information here that doesn't fit into other parts of the template_
14 changes: 6 additions & 8 deletions .github/ISSUE_TEMPLATE/DxT-user-story-template.md
Original file line number Diff line number Diff line change
@@ -1,48 +1,46 @@
---
name: DxT User Story Template
about: Create a new user story for the DxT eCR team
title: ''
title: ""
labels: DxT
assignees: ''

assignees: ""
---

## User Story

As a [user/persona], I want to [do a thing], so that I can [achieve a goal/outcome]


## Acceptance Criteria

_list out all expected functionality/requirements_

-
-

## Scenarios

_Write out scenarios that will help to ensure the functionality works as expected_

For example, this could look like:

- I click on the Score filter and a dropdown appears showing a slider.
- “1” and “10” are selected by default. The submit button is disabled.
- I then drag the left slider to “6” making the score 6 to 10.
- The text input below updates to display “6” and submit button is now active.
- I click submit and the dropdown closes.
- My search results are now updated.


## Design Notes

_Owned by design team - Attach link to design in dev mode and/or prototype, as well as any notes on visual details, interaction expectations, accessibility considerations, copy requirements_

[Link to Figma design in Dev mode]()
[Link to Figma prototype]()

-
-

_Screenshots below should not be used for working on this ticket - always refer to Figma design for most up-to-date designs:_

## Additional context

[OPTIONAL, delete if not needed]
[OPTIONAL, delete if not needed]
_Include any additional context or information here that doesn't fit into other parts of the template_
8 changes: 4 additions & 4 deletions .github/ISSUE_TEMPLATE/bug-template.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,9 @@
---
name: Streamline Bug Template
about: Capture bugs with this
title: ''
title: ""
labels: "\U0001F41B bug, Streamline eCR"
assignees: ''

assignees: ""
---

## Description
Expand All @@ -15,7 +14,7 @@ _Provide a high-level summary of the bug and what impact it has_

_List out the steps in detail to reproduce the bug_

1.
1.

## Expected Result

Expand All @@ -30,6 +29,7 @@ _Explain what's happening now when the bug is present. Attach screenshot if appl
_Provide an estimate for level of impact the bug has today by placing an X in the applicable bracket_

#### Priority

- [ ] **Low priority** _The bug does not have to be fixed immediately. High and medium priority bugs should be addressed first._
- [ ] **Medium priority** _Typically, medium-priority bugs do not affect customers directly and therefore can be fixed in the normal course of testing and development._
- [ ] **High priority** _High priority bugs must be addressed immediately. They often affect the app’s functionality and impact customers and their user experience. They must take priority._
Expand Down
21 changes: 12 additions & 9 deletions .github/ISSUE_TEMPLATE/qa-ticket-template.md
Original file line number Diff line number Diff line change
@@ -1,16 +1,17 @@
---
name: Streamline QA Ticket Template
about: Template for eCR Viewer QA efforts
title: ''
title: ""
labels: Streamline eCR quality-assurance-testing
assignees: ''

assignees: ""
---

## Action Requested

As part of our efforts to QA the eCR Viewer please thoroughly test the following eCR in the eCR viewer: [Link to eCR ##: ID]()

## Acceptance Criteria

- [ ] The eCR has been run through orchestration and the pipeline
- [ ] The eCR has been viewed in the Viewer and compared side by side to the original XML/HTML file
- [ ] The eCR is appearing properly in the non-integrated homepage table
Expand All @@ -19,18 +20,20 @@ As part of our efforts to QA the eCR Viewer please thoroughly test the following
## Basic process for comparing eCR Viewer output and original eCR

Steps to follow:

1. Go through the eCR Viewer fields from top to bottom
2. For every field in the eCR Viewer, do the following:
a. Check that you can find the data somewhere in the original HTML or XML
b. Check the content of the fields to see if they are the same or different
a. Check that you can find the data somewhere in the original HTML or XML
b. Check the content of the fields to see if they are the same or different
3. Then, looking at the original eCR HTML, do a quick scroll through to see if there is any data or sections present that we aren't showing in the eCR Viewer

Things to look out for:
- **Do we have only some of the data that you can see in the HTML or XML? Does it seem like it could be important information to users?**

- **Do we have only some of the data that you can see in the HTML or XML? Does it seem like it could be important information to users?**
- for ex: if the HTML says "Race: White, European" and ours says "Race: White" --> we will want to note that as a problem that we are missing some data that is available!
- **Does the formatting of the data look odd/different?**
- **Does the formatting of the data look odd/different?**
- for ex: did we get rid of page breaks such that narrative text is an overwhelming wall of text?
- **Are all addresses and phone numbers available in the HTML or XML available somewhere in our viewer?**
- **Are all addresses and phone numbers available in the HTML or XML available somewhere in our viewer?**
- we want to make sure we aren't missing any potential contact info for facilities that an end user may need to call for follow up
- **Do you notice anything that seems like a bug with our Viewer?**
- **Do you notice anything that seems like a bug with our Viewer?**
- for ex: is there a field showing up with no data in it? is there an edge case with the eCR data you're looking at that we didn't account for?
13 changes: 5 additions & 8 deletions .github/ISSUE_TEMPLATE/spike-template.md
Original file line number Diff line number Diff line change
@@ -1,33 +1,30 @@
---
name: Streamline Spike Template
about: Used for exploratory engineering spikes
title: ''
title: ""
labels: Streamline eCR
assignees: ''

assignees: ""
---

## What needs to be done

_Provide a summary of the task that needs to be completed_


## Why it needs to be done

_Describe the importance or impact of completing this task_


## Timebox

_How much time should be dedicated to this spike?_


## To-do list

_list out actions to be taken for this spike:_
- [ ]

- [ ]

## Additional context

[OPTIONAL, delete if not needed]
[OPTIONAL, delete if not needed]
_Include any additional context or information here that doesn't fit into other parts of the template_
15 changes: 5 additions & 10 deletions .github/ISSUE_TEMPLATE/task-template.md
Original file line number Diff line number Diff line change
@@ -1,37 +1,32 @@
---
name: Streamline Task Template
about: A generic template for any task that can be adapted for multiple uses
title: ''
title: ""
labels: Streamline eCR
assignees: ''

assignees: ""
---

## What needs to be done

_Provide a summary of the task that needs to be completed_


## Why it needs to be done

_Describe the importance or impact of completing this task_


## Acceptance Criteria

_List out all expected functionality/requirements_

-

-

## Technical Notes

_Owned by eng team - write out any important technical considerations such as: architecture plan/notes, data dependencies, testing plan, etc. Also link any tickets that are dependent on or related to this task_

-

-

## Additional context

[OPTIONAL, delete if not needed]
[OPTIONAL, delete if not needed]
_Include any additional context or information here that doesn't fit into other parts of the template_
Loading

0 comments on commit 2c0029c

Please sign in to comment.