Homepage loading & footer CSS #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmastephenson
commented
Nov 30, 2023
| // } | ||
| // } | ||
|
|
||
| @media all and (min-height: 35rem) { |
There was a problem hiding this comment.
We can blame my linter for all the other file changes here...this uncommenting is the only real change in this file!
emmastephenson
requested review from
KennethSkylight,
nickbristow and
sarahtress
|
@emmastephenson looking good! just one q:
everything else looks good to me though! |
@sarahtress yep! The screen is relatively narrow there. I tried for a while to get it to be more flexible (the 2 lines is happening sooner than I'd anticipate as the screen narrows) but no dice yet 🙃 if it's an issue I can keep trying to tweak the CSS though. Right now it's happening as soon as you go narrower than 1600px in width. |
|
@emmastephenson ok no prob! wouldn't worry about it too much at this stage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PULL REQUEST
Summary
Two small tweaks:
localhost:3000/) to render the upload tutorialRelated Issue
No related issue; just some fixes
Additional Information
Home page before
Home page after (diff window sizes)