Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up local HAPI server for e2e tests #90

Merged
merged 26 commits into from
Oct 30, 2024

Conversation

m-goggins
Copy link
Collaborator

@m-goggins m-goggins commented Oct 29, 2024

PULL REQUEST

Summary

This PR adds a new docker-compose-e2e-tests.yaml that spins up a local HAPI FHIR server and loads the Hyper Unlucky patient into the server. I chose to add a new dock compose file to prevent the primary, docker compose file from requiring HAPI, which is only used for e2e tests, but open to hearing others' ideas.

I also updated the e2e tests to manually select the local instance of the HAPI server, which is now available in the drop down.

Some lessons learned:

  • Our flaky issues stemmed from the Public HAPI server, which we thought was the issue, but it was nice to get additional confirmation. We should probably continue to make sure our e2e tests remain divorced from external services.
  • We did not end up needing to use networks or the container names when connecting between containers either locally or in github actions. The only place where the container name is used instead of localhost is in fhir_servers.

Related Issue

Fixes # phdi 2758

Acceptance Criteria

Please copy the acceptance criteria from your ticket and paste it here for your reviewer(s)

For frontend PR’s - include a description (including anything that’s out of scope) for what you want the designers to review

  • ex: “Check out the whitespace on the page, as well as the dropdowns in the form. Here is the corresponding Figma link. You can ignore everything else. Also, the button at the bottom doesn’t work now”

Additional Information

Checklist

  • If this code affects the other scrum team, have they been notified? (In Slack, as reviewers, etc.)

@m-goggins m-goggins changed the title Marcelle/2758 set up local hapi server for testing Set up local HAPI server for e2e tests Oct 30, 2024
@m-goggins m-goggins marked this pull request as ready for review October 30, 2024 17:36
Copy link
Collaborator

@DanPaseltiner DanPaseltiner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for sorting all of this out!

query-connector/src/app/constants.ts Show resolved Hide resolved
Copy link
Collaborator

@bamader bamader left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am so happy this is done 😭 😎

Copy link
Collaborator

@fzhao99 fzhao99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks so much for doing this! 🤞 this solves all our problems

@m-goggins m-goggins merged commit 9950139 into main Oct 30, 2024
5 checks passed
@m-goggins m-goggins deleted the marcelle/2758-set-up-local-hapi-server-for-testing branch October 30, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants