do some ts magic to get around the switch setup #46
Conversation
…ery-connector into bob/fix-ts-error
fzhao99
changed the title
| ): Promise<unknown[]> { | ||
| let resourceArray: unknown[] = []; | ||
| ): Promise<FhirResource[]> { | ||
| let resourceArray: FhirResource[] = []; |
There was a problem hiding this comment.
@robertandremitchell pushed the type checking from where you had it down a level to where we're making contact against the relevant FHIR response, which feels like the part of the stack where we should check for it. RN just logging out a mismatch in the event that we have an issue rather than "properly" handling the issue based on the scope of the ticket, but lmk if you have any issues here
Also renamed the function accordingly
There was a problem hiding this comment.
I think that makes sense. I had tinkered with moving it yesterday but it felt like it was getting more complex. this definitely simplifies it a lot, which is great!
| ): Promise<unknown[]> { | ||
| let resourceArray: unknown[] = []; | ||
| ): Promise<FhirResource[]> { | ||
| let resourceArray: FhirResource[] = []; |
There was a problem hiding this comment.
I think that makes sense. I had tinkered with moving it yesterday but it felt like it was getting more complex. this definitely simplifies it a lot, which is great!
fzhao99
merged commit 23ca516
into
rob/2783-fix-errors-generated-by-eslintrcjson
Adds a few utility classes to get around Typescript union type wonkiness